Only build the fuzz crate on main
#14478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
changed the title
ruff crate on mainfuzz crate on main
|
|
I generally found the fuzzer CI job useful because I never build the fuzzer locally. I often not even build the fuzzer locally when I break the build, instead I just push a fix and see if CI breaks now (because it requires some setup before you can build it successfully). That workflow no longer works. I have never felt blocked by the fuzzer build. The slowest job, but very high signal, is the ecosystem check. That's what I'm waiting for. |
MichaReiser
added a commit
that referenced
this pull request
Dec 13, 2024
## Summary This reverts #14478 I now broke main twice because I wasn't aware that the API was used by the fuzzer. ## Test Plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not actually doing anything per pull request and it's pretty slow? xref #14469
It seems useful to build on
mainstill to find build regressions? e.g. #9368