Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzer fails to build memchr #9368

Closed
zanieb opened this issue Jan 2, 2024 · 9 comments
Closed

Fuzzer fails to build memchr #9368

zanieb opened this issue Jan 2, 2024 · 9 comments
Assignees
Labels
ci Related to internal CI tooling

Comments

@zanieb
Copy link
Member

zanieb commented Jan 2, 2024

See https://github.com/astral-sh/ruff/actions/runs/7390478731/job/20105487965

@zanieb zanieb added the ci Related to internal CI tooling label Jan 2, 2024
zanieb added a commit that referenced this issue Jan 2, 2024
The job is failing to compile. We should resolve separately but I am
disabling for now since it breaks pull requests.

See #9368
@charliermarsh charliermarsh self-assigned this Jan 2, 2024
@charliermarsh
Copy link
Member

@addisoncrump -- Any chance it's obvious to you why this started failing?

@addisoncrump
Copy link
Contributor

The CI tells the truth 🕊️ : https://github.com/astral-sh/ruff/actions/runs/7390478731/job/20105487965#step:6:39

It seems that musl is being set somehow.

@addisoncrump
Copy link
Contributor

Notably, it seems that the bin provided from binstall is a musl binary: https://github.com/astral-sh/ruff/actions/runs/7390478731/job/20105487965#step:5:39
This did not use to be the case: https://github.com/astral-sh/ruff/actions/runs/7389857960/job/20103579755#step:5:39

At a guess, this is some weird "rust binary expects consistency" issue. I'll try to repro locally.

@addisoncrump
Copy link
Contributor

Yup, just verified locally: building with the version provided by cargo-fuzz upstream causes a build failure as it expects musl.

@charliermarsh
Copy link
Member

Nice, thank you. I was able to get CI passing by pinning to the previous minor: #9372

@addisoncrump
Copy link
Contributor

Resolved at record pace 🚀 I'll communicate upstream to try to resolve this there so we can remove the pinning. Don't close this issue yet?

@MichaReiser
Copy link
Member

Resolved at record pace 🚀 I'll communicate upstream to try to resolve this there so we can remove the pinning. Don't close this issue yet?

@addisoncrump Let us know when we're good to close the issue.

@addisoncrump
Copy link
Contributor

You can close it this side, there's now a tracking issue upstream: taiki-e/install-action#352

@charliermarsh
Copy link
Member

Thanks!

zanieb added a commit that referenced this issue Nov 20, 2024
It's not actually doing anything per pull request and it's pretty slow?
xref #14469

It seems useful to build on `main` still to find build regressions? e.g.
#9368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to internal CI tooling
Projects
None yet
Development

No branches or pull requests

4 participants