This repository has been archived by the owner on Nov 22, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikeharder
commented
Apr 17, 2018
•
edited
Loading
edited
- Started failing after dependencies.props update: 46e3c69
- Issue to un-skip: Un-skip ANCMv2 in-proc chunked tests #110
- Started failing after recent update to dependencies.props - Issue to un-skip: #110
muratg
approved these changes
Apr 17, 2018
@muratg: Do I need any further approval before merging to dev? I'm not sure if we branched for 2.1 yet, so this might need ask mode approval. |
I wouldn't think so, but just in case: @pranavkm any objections to take this one? It's just skipping tests for stuff we won't ship so it should be safe. |
@muratg: Dev is now open for this repo, so I will merge to dev once AppVeyor passes. Do you think this should be ported to 2.1? |
Sounds good for dev. I'm going to leave it up to @ryanbrandenburg to decide if he wants this in Release/2.1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.