Skip to content
This repository has been archived by the owner on Nov 22, 2018. It is now read-only.

Skip ANCM v2 in-proc chunked tests #111

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

mikeharder
Copy link
Contributor

@mikeharder mikeharder commented Apr 17, 2018

- Started failing after recent update to dependencies.props
- Issue to un-skip: #110
@mikeharder
Copy link
Contributor Author

@muratg: Do I need any further approval before merging to dev? I'm not sure if we branched for 2.1 yet, so this might need ask mode approval.

@muratg
Copy link
Contributor

muratg commented Apr 17, 2018

I wouldn't think so, but just in case: @pranavkm any objections to take this one?

It's just skipping tests for stuff we won't ship so it should be safe.

@mikeharder
Copy link
Contributor Author

mikeharder commented Apr 17, 2018

@muratg: Dev is now open for this repo, so I will merge to dev once AppVeyor passes. Do you think this should be ported to 2.1?

@muratg
Copy link
Contributor

muratg commented Apr 17, 2018

Sounds good for dev. I'm going to leave it up to @ryanbrandenburg to decide if he wants this in Release/2.1.

@jkotalik
Copy link
Contributor

jkotalik commented Apr 17, 2018 via email

@mikeharder mikeharder merged commit a30faf1 into dev Apr 17, 2018
@mikeharder mikeharder deleted the mikeharder/disable-ancm2-chunked-tests branch April 17, 2018 03:57
Tratcher pushed a commit that referenced this pull request May 1, 2018
- Started failing after dependencies.props update: 46e3c69
- Issue to un-skip: #110
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants