Skip to content
This repository has been archived by the owner on Nov 22, 2018. It is now read-only.

Un-skip ANCMv2 in-proc chunked tests #110

Closed
mikeharder opened this issue Apr 17, 2018 · 7 comments
Closed

Un-skip ANCMv2 in-proc chunked tests #110

mikeharder opened this issue Apr 17, 2018 · 7 comments
Assignees
Milestone

Comments

@mikeharder
Copy link
Contributor

mikeharder commented Apr 17, 2018

After a recent update to dependencies.props (46e3c69), two tests for ANCMv2 in-proc chunked started failing. The tests have been temporarily skipped to unblock the build (#111). The root cause should be investigated and fixed, and the tests un-skipped.

Build

http://aspnetci/viewLog.html?buildId=448886&tab=buildResultsDiv&buildTypeId=Lite_ServerTests

Tests

ServerComparison.FunctionalTests.ResponseTests.ServerComparison.FunctionalTests.ResponseTests.ResponseFormats_IISExpress_Chunked
  (runtimeFlavor: CoreClr, applicationType: Standalone, hostingModel: InProcess, additionalPublishParameters: " /p:ANCMVersion=V2")
ServerComparison.FunctionalTests.ResponseTests.ServerComparison.FunctionalTests.ResponseTests.ResponseFormats_IISExpress_Chunked
  (runtimeFlavor: CoreClr, applicationType: Portable, hostingModel: InProcess, additionalPublishParameters: " /p:ANCMVersion=V2")

Error

/chunked, chunked?
Expected: True
Actual:   (null)
   at ServerComparison.FunctionalTests.ResponseTests.CheckChunkedAsync(HttpClient client, ILogger logger) in D:\b\w\14f303341b884b1a
@mikeharder mikeharder added this to the 2.1.0-rc1 milestone Apr 17, 2018
mikeharder added a commit that referenced this issue Apr 17, 2018
- Started failing after recent update to dependencies.props
- Issue to un-skip: #110
@muratg
Copy link
Contributor

muratg commented Apr 17, 2018

@mikeharder did you mean to put this in 2.2.0-mq?

@mikeharder
Copy link
Contributor Author

@muratg: Your call, I'm not sure when these tests should be un-skipped. I put it in rc1 in case it's important to do sooner.

@muratg muratg modified the milestones: 2.1.0-rc1, 2.2.0-mq Apr 17, 2018
@muratg
Copy link
Contributor

muratg commented Apr 17, 2018

Cool. Based on the current plans, we probably won't have time in RC1.

mikeharder added a commit that referenced this issue Apr 17, 2018
- Started failing after dependencies.props update: 46e3c69
- Issue to un-skip: #110
Tratcher pushed a commit that referenced this issue May 1, 2018
- Started failing after dependencies.props update: 46e3c69
- Issue to un-skip: #110
@jkotalik
Copy link
Contributor

@Tratcher did you mention that these tests were fixed by @pakrym latest check-in to IISIntegration?

@Tratcher
Copy link
Member

Yes, I'll re-enable them.

@muratg
Copy link
Contributor

muratg commented Jun 8, 2018

@Tratcher was this re-enabled?

@Tratcher
Copy link
Member

Tratcher commented Jun 8, 2018

Yes, resolved by b30f0d3#diff-6b87abfdf2711c4cb51dbd0cfb0dba11

@Tratcher Tratcher closed this as completed Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants