Allow optional quotes around tag helper directives #647
Conversation
| @@ -285,7 +289,7 @@ protected void BaseTypeDirective(string noTypeNameError, Func<string, SpanChunkG | |||
| Output(SpanKind.Code, AcceptedCharacters.AnyExceptNewline); | |||
| } | |||
|
|
|||
| private void TagHelperDirective(string keyword, ISpanChunkGenerator chunkGenerator) | |||
| private void TagHelperDirective(string keyword, Func<string, ISpanChunkGenerator> chunkGeneratorThunk) | |||
There was a problem hiding this comment.
chunkGeneratorThunk? lol wha name is that
There was a problem hiding this comment.
Such an awesome name. I can change it to chunkGeneratorFactory if that's the more common term in the codebase.
|
You're missing a piece in this PR. The line mappings of the during design time will be off for |
|
⌚ |
|
Updated |
1 similar comment
|
Updated |
| @@ -1,5 +1,5 @@ | |||
| @addTagHelper something, nice | |||
| @removeTagHelper doesntmatter, nice | |||
| @addTagHelper "something, nice" | |||
There was a problem hiding this comment.
Do this for a few of the design time code generation tests so we can validate line mappings. Should be one for each, add, remove, prefix
|
⌚ for line mapping tests. |
pranavkm
force-pushed
the
prkrishn/tag-helper-quotes
branch
from
d1e8614
to
53a4a7b
Compare
|
Updated |
| @@ -0,0 +1,10 @@ | |||
| @tagHelperPrefix THS | |||
There was a problem hiding this comment.
Whaaa, nononononono. I was saying that you could just intermingle quotes/non-quotes in existing tests that have design-time tests for them already. Same with below. These things don't deserve their own dedicated tests
pranavkm
force-pushed
the
prkrishn/tag-helper-quotes
branch
from
53a4a7b
to
e1244f6
Compare
|
Updated |
| @@ -98,6 +99,8 @@ private void VisitTagHelperDirectiveChunk(string text, Chunk chunk) | |||
| Writer.WriteVariableDeclaration("string", TagHelperDirectiveSyntaxHelper, "null"); | |||
| } | |||
|
|
|||
| var text = ((Span)chunk.Association).Content.Trim(); | |||
There was a problem hiding this comment.
This doesn't work does it? What happens if the content has quotes? Wont the values come out double quoted?
There was a problem hiding this comment.
The old code added quotes back. What should this be doing?
|
⌚ |
pranavkm
force-pushed
the
prkrishn/tag-helper-quotes
branch
from
e1244f6
to
3c00a3a
Compare
pranavkm
force-pushed
the
prkrishn/tag-helper-quotes
branch
from
3c00a3a
to
e1aa888
Compare
|
|
Fixes #636