Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Make @addTagHelper, @removeTagHelper and @tagHelperPrefix optionally accept quotes around their values #636

Closed
NTaylorMullen opened this issue Dec 9, 2015 · 9 comments
Assignees
Milestone

Comments

@NTaylorMullen
Copy link
Member

We made a change to the addTagHelper, removeTagHelper and tagHelperPrefix directives to disallow quotes around their values. This happens to really mess with tooling when using rc1 with rc2+ bits. Not to mention, it doesn't hurt to have quotes. We should allow them optionally like we did in RC1.

/cc @DamianEdwards

@Eilon Eilon added this to the 4.0.0-rc2 milestone Dec 15, 2015
@Eilon
Copy link
Member

Eilon commented Dec 15, 2015

  1. Let's re-add support for quotes, but make it some kind of warning.
  2. Open a bug for RTM to remove all support for quotes.

@DamianEdwards
Copy link
Member

@NTaylorMullen pls ensure you work with tooling to ensure their RC2 release supports both quotes and without (if anything special is required at all).

@mikes-gh
Copy link

@NTaylorMullen Yes I noticed VS complains without quotes with squiggly red line after these changes

@pranavkm
Copy link
Contributor

@DamianEdwards we haven't added warnings to the editor as part of this change (an API to send warnings isn't available as yet). We silently read and ignore quotes. Do you think this warrants a follow up work item?

@DamianEdwards
Copy link
Member

I think we should just support both and be done with it. No need for warnings.

@pranavkm
Copy link
Contributor

Great, that's how it behaves now.

@Eilon
Copy link
Member

Eilon commented Dec 29, 2015

Do we need to close out any bug that says to remove/alter the warning behavior in the future?

@pranavkm
Copy link
Contributor

Nope. All we need to do is delete this comment - #636 (comment)

@Eilon
Copy link
Member

Eilon commented Dec 29, 2015

Ah ok cool (leave the comment there, just say we didn't do it.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants