-
Notifications
You must be signed in to change notification settings - Fork 225
Make @addTagHelper, @removeTagHelper and @tagHelperPrefix optionally accept quotes around their values #636
Comments
|
@NTaylorMullen pls ensure you work with tooling to ensure their RC2 release supports both quotes and without (if anything special is required at all). |
@NTaylorMullen Yes I noticed VS complains without quotes with squiggly red line after these changes |
@DamianEdwards we haven't added warnings to the editor as part of this change (an API to send warnings isn't available as yet). We silently read and ignore quotes. Do you think this warrants a follow up work item? |
I think we should just support both and be done with it. No need for warnings. |
Great, that's how it behaves now. |
Do we need to close out any bug that says to remove/alter the warning behavior in the future? |
Nope. All we need to do is delete this comment - #636 (comment) |
Ah ok cool (leave the comment there, just say we didn't do it.) |
We made a change to the
addTagHelper
,removeTagHelper
andtagHelperPrefix
directives to disallow quotes around their values. This happens to really mess with tooling when using rc1 with rc2+ bits. Not to mention, it doesn't hurt to have quotes. We should allow them optionally like we did in RC1./cc @DamianEdwards
The text was updated successfully, but these errors were encountered: