Adding telemetry publish for unhandled exceptions to developer exception page

[JunTaoLuo]

For #180 cc @Eilon @Tratcher

[dnfclas]

Hi @JunTaoLuo, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

[Tratcher]

Assert NotNull HostingEndRequest

[JunTaoLuo]

I'm guessing I should Assert NotNull HostingBeginRequest as well?

[Tratcher]

shrug that's out of scope of this change.

[Tratcher]

@avanderhoorn @rynowak

[Tratcher]

Include the bug number in the commit message.

[JunTaoLuo]

@Tratcher I will add the bug number once I squash all commits

[avanderhoorn]

When is this event triggered as apposed to "Microsoft.AspNet.Hosting.UnhandledException" here.

[JunTaoLuo]

@avanderhoorn When the developer exception page successfully displays. Since the exception will be suppressed, we want to publish it to telemetry source as diagnostic unhandled exception. If for other reasons displaying the exception fails, the exception will be bubbled up to hosting and will trigger the telemetry publish there.

[avanderhoorn]

Great, so in the case that this event happens, we wont get the hosting one.

[JunTaoLuo]

@avanderhoorn right. In fact, without this change, the hosting one will never trigger any ways since the exception is not rethrown.

[avanderhoorn]

Makes sense. Thanks!

[Tratcher]

We also need this here: https://github.com/aspnet/Diagnostics/blob/dev/src/Microsoft.AspNet.Diagnostics/ExceptionHandler/ExceptionHandlerMiddleware.cs#L66

[JunTaoLuo]

@Tratcher I was asking for that in my previous comment in the issue #180 . That error is technically handled and I wasn't sure if that should also publish to telemetry.

[avanderhoorn]

For our part we would like to know about that exception too.

[JunTaoLuo]

@avanderhoorn cool. I added the telemetry publish for exception handler as well. It's going to publish to Microsoft.AspNet.Diagnostics.HandledException just to differentiate from the unhandled exception from developer exception page, is that good?

[avanderhoorn]

Sounds great!

On Friday, October 2, 2015, John Luo [email protected] wrote:

@avanderhoorn https://github.com/avanderhoorn cool. I added the
telemetry publish for exception handler as well. It's going to publish to
Microsoft.AspNet.Diagnostics.HandledException just to differentiate from
the unhandled exception from developer exception page, is that good?

—
Reply to this email directly or view it on GitHub
#185 (comment).

[JunTaoLuo]

I'm going to take that as a All tests passed so I'll merge to dev.

[avanderhoorn]

Thanks!