Skip to content
This repository has been archived by the owner on Dec 8, 2018. It is now read-only.

Publish unhandled errors to telemetry source #180

Closed
Eilon opened this issue Sep 14, 2015 · 3 comments
Closed

Publish unhandled errors to telemetry source #180

Eilon opened this issue Sep 14, 2015 · 3 comments
Assignees
Milestone

Comments

@Eilon
Copy link
Member

Eilon commented Sep 14, 2015

Publish this:

  1. Unhandled errors - wherever in there's a catch that doesn't rethrow (same place that stuff is logged right now, probably)
    • Need to do this in both DeveloperExceptionPage and ErrorHandler

Example in MVC: https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNet.Mvc.Core/Actions/MvcRouteHandler.cs#L73-L78

@Eilon
Copy link
Member Author

Eilon commented Sep 14, 2015

Related: aspnet/Hosting#354

@JunTaoLuo
Copy link
Contributor

Just to confirm, the only unhandled exception that needs to be written to telemetry is at DevelopperExceptionPageMiddleware.cs#L86 where we just create an exception page. All other instance of Invoke in DevelopperExceptionPageMiddleware.cs will end up throwing an exception that bubbles up to hosting.

Similarly ExceptionHandlerMiddleware.cs will throw unhandled exceptions up to hosting or handle it at ExceptionHandlerMiddleware.cs#L65

cc @Tratcher @Eilon

@Tratcher
Copy link
Member

Tratcher commented Oct 1, 2015

Correct, you only need telemetry for app exceptions that are not re-thrown.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants