Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't allow files in deps attr #318

Merged
merged 1 commit into from
Mar 24, 2024
Merged

fix: don't allow files in deps attr #318

merged 1 commit into from
Mar 24, 2024

Conversation

mattem
Copy link
Collaborator

@mattem mattem commented Mar 23, 2024

Remove the allow_files = True from the deps attr of py_libaray (they are inherited by py_binary). This allowed users to place non-existent targets into deps.

Closes #316

@mattem mattem requested a review from alexeagle March 23, 2024 19:29
@alexeagle alexeagle merged commit f45f1ed into main Mar 24, 2024
12 checks passed
@alexeagle alexeagle deleted the no_files branch March 24, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Open Source
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: py_binary seems to ignore nonexistent dependencies
2 participants
@mattem @alexeagle