Skip to content

Commit

Permalink
fix: don't allow files in deps attr (#318)
Browse files Browse the repository at this point in the history
Remove the `allow_files = True` from the `deps` attr of `py_libaray`
(they are inherited by `py_binary`). This allowed users to place
non-existent targets into `deps`.

Closes #316
  • Loading branch information
Matt Mackay authored Mar 24, 2024
1 parent df191bd commit f45f1ed
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion py/private/py_library.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,6 @@ _attrs = dict({
),
"deps": attr.label_list(
doc = "Targets that produce Python code, commonly `py_library` rules.",
allow_files = True,
providers = [[PyInfo], [PyVirtualInfo]],
),
"data": attr.label_list(
Expand Down

0 comments on commit f45f1ed

Please sign in to comment.