Fixed: Two AutoDLLPlugin's overwrite each other #30

cgatian · 2017-07-06T16:54:07Z

Trying to utilize this plugin and found that when you add two AutoDLLPlugins to the webpack config the last one wins in creating a manifest in .cache.

To reproduce add two plugins, and attempt a build.

asfktz · 2017-07-06T19:24:12Z

Hi, @cgatian

Thanks for reporting.
I also encountered this bug a few days ago.
It's a top priority, I'll let you know when it's fixed.

asfktz · 2017-07-06T19:57:17Z

BTW, would you mind sharing what your use case was for more than one instance of the plugin?

cgatian · 2017-07-06T20:39:52Z

@asfktz we were considering migration to this plugin instead of the webpack-dll-bundles-plugin as it hasn't received much attention in the last 6 months,

The setup this webpack starter has basically outlines what we were trying to do. They create two DLL bundles, one for polyfills and a second for vendor. My understanding is, since DLLs should only really be used during development creating two instances really has no benefit. (Please correct me if I'm wrong)

viankakrisna · 2017-07-07T02:54:21Z

I've anticipated this issue in #13 but does not have a fixture yet. Adding a fixture for this functionality would be a good start so we can test it thoroughly. :)

asfktz · 2017-07-07T14:21:46Z

@cgatian turns out that using DLL in production is not a bad idea.

I forked your project to better understand your use case. I don't see more than one instance of DllBundlesPlugin in there.

I do see two bundles, polyfills and vendor, but that should be no problem with AutoDllPlugin.

I see that you have separate configs for each environment,
having one instance in each should not be a problem because they run separately.

But it will trigger a rebuild currently. it will be fixed soon.

I plan to fix the multiple instances bug anyway.

I noticed that when I replace DllBundlesPlugin with AutoDllPlugin:

new AutoDllPlugin({
        debug: true,
        inject: true,
        context: helpers.root(),
        filename: '[name]_[hash].js',
        path: './dll',
        entry: {
          polyfills: [
            'core-js',
            'zone.js/dist/zone.js',
            'zone.js/dist/long-stack-trace-zone'
          ],
          vendor: [
            '@angular/platform-browser',
            '@angular/platform-browser-dynamic',
            '@angular/core',
            '@angular/common',
            '@angular/forms',
            '@angular/http',
            '@angular/router',
            '@angularclass/hmr',
            'rxjs',
          ]
        }
 }),

An error is thrown on npm start

....

======================================================================================
 46% building modules 303/306 modules 3 active ...rc/app/+detail/+child-detail/index.ts================================== ng-router-loader ==================================
Importer:    /Users/asafkatz/dev/angular-starter/src/app/+barrel/barrel.routes.ts
Raw Request: ./+child-barrel#ChildBarrelModule
Replacement: function() { return import('/Users/asafkatz/dev/angular-starter/src/app/+barrel/+child-barrel/index')  .then( function(module) { return module['ChildBarrelModule']; } ); }
======================================================================================
2454ms building modules
9ms sealing
0ms optimizing
0ms basic module optimization
4ms module optimization
 75% advanced module optimization
/Users/asafkatz/dev/angular-starter/node_modules/autodll-webpack-plugin/node_modules/webpack/lib/ModuleReason.js:27
			if(!this.module._chunks.has(oldChunk))
                          ^
TypeError: Cannot read property 'has' of undefined
    at ModuleReason.rewriteChunks (/Users/asafkatz/dev/angular-starter/node_modules/autodll-webpack-plugin/node_modules/webpack/lib/ModuleReason.js:27:27)
    at DelegatedModule.rewriteChunkInReasons (/Users/asafkatz/dev/angular-starter/node_modules/autodll-webpack-plugin/node_modules/webpack/lib/Module.js:169:20)
    at Compilation.compilation.plugin (/Users/asafkatz/dev/angular-starter/node_modules/webpack/lib/optimize/RemoveParentModulesPlugin.js:82:15)
    at Compilation.applyPluginsBailResult1 (/Users/asafkatz/dev/angular-starter/node_modules/tapable/lib/Tapable.js:120:27)
    at Compilation.seal (/Users/asafkatz/dev/angular-starter/node_modules/webpack/lib/Compilation.js:574:14)
    at /Users/asafkatz/dev/angular-starter/node_modules/webpack/lib/Compiler.js:493:16
    at /Users/asafkatz/dev/angular-starter/node_modules/tapable/lib/Tapable.js:225:11
    at _addModuleChain (/Users/asafkatz/dev/angular-starter/node_modules/webpack/lib/Compilation.js:481:11)
    at processModuleDependencies.err (/Users/asafkatz/dev/angular-starter/node_modules/webpack/lib/Compilation.js:452:13)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)
EXIT RUNTIME
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] webpack-dev-server: `node --max_old_space_size=4096 node_modules/webpack-dev-server/bin/webpack-dev-server.js "--config" "config/webpack.dev.js" "--open" "--progress" "--profile" "--watch" "--content-base" "src/"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] webpack-dev-server script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/asafkatz/.npm/_logs/2017-07-07T14_13_04_021Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] server:dev: `npm run webpack-dev-server -- --config config/webpack.dev.js --open --progress --profile --watch --content-base src/`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] server:dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/asafkatz/.npm/_logs/2017-07-07T14_13_04_053Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] start: `npm run server:dev`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/asafkatz/.npm/_logs/2017-07-07T14_13_04_086Z-debug.log

I plan to investigate it.

cgatian · 2017-07-07T14:39:30Z

@asfktz yes they can be used in production in very clever scenarios. However, I believe when you're actually using them in production youre going to want to be very strategic in how the DLLs are built. Something I dont think should be totally automated by a package, but on a case by case basis.

Thanks for taking a look. 👍

taehwanno · 2017-07-11T15:53:57Z

An error is thrown on npm start

@asfktz I think because autodll-webpack-plugin depends on webpack v3, angular-starterkit using webpack v2 will fail in running npm start. My private project (webpack v2.4.1) also fail in running npm start (execute webpack-dev-server). but by updating to webpackv3, script succeed.

/Users/notaehwan/modusign-client/node_modules/autodll-webpack-plugin/node_modules/webpack/lib/ModuleReason.js:27
			if(!this.module._chunks.has(oldChunk))
			                       ^

TypeError: Cannot read property 'has' of undefined
    at ModuleReason.rewriteChunks (/Users/notaehwan/modusign-client/node_modules/autodll-webpack-plugin/node_modules/webpack/lib/ModuleReason.js:27:27)
    at DelegatedModule.rewriteChunkInReasons (/Users/notaehwan/modusign-client/node_modules/autodll-webpack-plugin/node_modules/webpack/lib/Module.js:169:20)
    at Compilation.compilation.plugin (/Users/notaehwan/modusign-client/node_modules/webpack/lib/optimize/RemoveParentModulesPlugin.js:82:15)
    at Compilation.applyPluginsBailResult1 (/Users/notaehwan/modusign-client/node_modules/tapable/lib/Tapable.js:120:27)
    at Compilation.seal (/Users/notaehwan/modusign-client/node_modules/webpack/lib/Compilation.js:570:14)
    at /Users/notaehwan/modusign-client/node_modules/webpack/lib/Compiler.js:488:16
    at /Users/notaehwan/modusign-client/node_modules/tapable/lib/Tapable.js:225:11
    at _addModuleChain (/Users/notaehwan/modusign-client/node_modules/webpack/lib/Compilation.js:477:11)
    at processModuleDependencies.err (/Users/notaehwan/modusign-client/node_modules/webpack/lib/Compilation.js:448:13)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

asfktz · 2017-07-11T17:12:52Z

Hi @taehwanno,
Thanks for the insight!

Interesting, even if I set webpack as a peerDependency of autodll-webpack-plugin like so:

"peerDependencies": {
    "webpack": ">= 2.0.0"
}

I still get this error on angular-starterkit.

But like in your case, upgrading to webpack v3 solves it.

I'll dive into it to see what I can do to fix it from my side.

@cgatian also wanted you to know that your original issue with the multiple instances was fixed in 0.1.0

asfktz · 2017-07-11T19:22:44Z

@taehwanno are you using awesome-typescript-loader?

I noticed that it works with webpack 2.6.1 if I replace awesome-typescript-loader with ts-loader

I released a new version. webpack is now a peerDependency.

taehwanno · 2017-07-12T01:57:00Z

are you using awesome-typescript-loader?

Nope. When I retry autodll-webpack-plugin with v0.2.1 in my private project, script succeeds without errors.

asfktz · 2017-07-12T06:03:22Z

@taehwanno oh, that's good news (:

asfktz · 2017-07-12T14:38:00Z

@cgatian is updating to webpack v3 an option for you?

cgatian · 2017-07-12T16:02:24Z

I was trying this in webpack 3. Haven't tried since you released the new version.

…

On Wed, Jul 12, 2017, 10:38 AM Asaf Katz ***@***.***> wrote: @cgatian <https://github.com/cgatian> is updating to webpack v3 an option for you? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABq8agypnYWP8QGKxxBUwt7vo3hugGzKks5sNNpIgaJpZM4OP6OR> .

asfktz · 2017-07-12T17:20:10Z

@cgatian I already did it in my fork, so I created a PR for you to use if you like:
PatrickJS/PatrickJS-starter#1828

swernerx · 2017-07-18T16:28:26Z

Just want to add that double instances of the plugin could also be relevant when using the multi compiler feature of Webpack. We use that for efficient SSR (universal) bundling. See also #43

I would be fine to pass over some specific naming for the caching/output. I does the same already for webpacks new Cache-Loader:

  {
    loader: "cache-loader",
    options: {
      cacheDirectory: resolve(ROOT, `.cache/loader-${CACHE_HASH}-${config.target}-${config.env}`)
    }
  }

asfktz added the bug label Jul 6, 2017

asfktz referenced this issue Jul 12, 2017

0.2.0

237f6db

asfktz mentioned this issue Jul 12, 2017

Add AutoDLL PatrickJS/PatrickJS-starter#1828

Closed

asfktz changed the title ~~Two AutoDLLPlugin's overwrite each other~~ Fixed: Two AutoDLLPlugin's overwrite each other Jul 14, 2017

asfktz removed the bug label Jul 14, 2017

toralux mentioned this issue Aug 5, 2017

use Set for ModuleReason chunk rewriting webpack/webpack#5060

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed: Two AutoDLLPlugin's overwrite each other #30

Fixed: Two AutoDLLPlugin's overwrite each other #30

cgatian commented Jul 6, 2017

asfktz commented Jul 6, 2017 •

edited

Loading

asfktz commented Jul 6, 2017 •

edited

Loading

cgatian commented Jul 6, 2017

viankakrisna commented Jul 7, 2017

asfktz commented Jul 7, 2017

cgatian commented Jul 7, 2017 •

edited

Loading

taehwanno commented Jul 11, 2017 •

edited

Loading

asfktz commented Jul 11, 2017 •

edited

Loading

asfktz commented Jul 11, 2017 •

edited

Loading

taehwanno commented Jul 12, 2017

asfktz commented Jul 12, 2017

asfktz commented Jul 12, 2017

cgatian commented Jul 12, 2017 via email

asfktz commented Jul 12, 2017

swernerx commented Jul 18, 2017 •

edited

Loading

Fixed: Two AutoDLLPlugin's overwrite each other #30

Fixed: Two AutoDLLPlugin's overwrite each other #30

Comments

cgatian commented Jul 6, 2017

asfktz commented Jul 6, 2017 • edited Loading

asfktz commented Jul 6, 2017 • edited Loading

cgatian commented Jul 6, 2017

viankakrisna commented Jul 7, 2017

asfktz commented Jul 7, 2017

cgatian commented Jul 7, 2017 • edited Loading

taehwanno commented Jul 11, 2017 • edited Loading

asfktz commented Jul 11, 2017 • edited Loading

asfktz commented Jul 11, 2017 • edited Loading

taehwanno commented Jul 12, 2017

asfktz commented Jul 12, 2017

asfktz commented Jul 12, 2017

cgatian commented Jul 12, 2017 via email

asfktz commented Jul 12, 2017

swernerx commented Jul 18, 2017 • edited Loading

asfktz commented Jul 6, 2017 •

edited

Loading

asfktz commented Jul 6, 2017 •

edited

Loading

cgatian commented Jul 7, 2017 •

edited

Loading

taehwanno commented Jul 11, 2017 •

edited

Loading

asfktz commented Jul 11, 2017 •

edited

Loading

asfktz commented Jul 11, 2017 •

edited

Loading

swernerx commented Jul 18, 2017 •

edited

Loading