Skip to content

Commit

Permalink
0.2.0
Browse files Browse the repository at this point in the history
  • Loading branch information
asfktz committed Jul 11, 2017
1 parent 6d9d477 commit 237f6db
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "autodll-webpack-plugin",
"version": "0.1.0",
"version": "0.2.0",
"description": "",
"main": "lib/index.js",
"scripts": {
Expand Down

4 comments on commit 237f6db

@sudo-suhas
Copy link
Collaborator

@sudo-suhas sudo-suhas commented on 237f6db Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @asfktz, I was just wondering, was there any breaking change in this version? I only recently came to realise that rules for v0.x.y are slightly different from v1.x.y. For dependency declared as ^0.1.0, package managers will not install v0.2.0 even though they are the same major version.

@asfktz
Copy link
Owner Author

@asfktz asfktz commented on 237f6db Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sudo-suhas,

Yeah, I moved webpack from dependencies to peerDependencies, because of #30.
I wasn't sure whether it's a breaking change or not, so I decided to go safe with this one.

I also maintain a CHANGELOG now.

@sudo-suhas
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I moved webpack from dependencies to peerDependencies, because of #30.
I wasn't sure whether it's a breaking change or not, so I decided to go safe with this one.

👍 Makes sense.

I also maintain a CHANGELOG now.

Yea I saw that.. Looks absolutely great! I was wondering where I could mention that 😉
Do you think the changelog should call out possible breaking changes?

@asfktz
Copy link
Owner Author

@asfktz asfktz commented on 237f6db Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the changelog should call out possible breaking changes?

Yeah, I agree. I mention that it's a break change the way webpack's doing it, but it's not clear enough.

Please sign in to comment.