You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Hey @asfktz, I was just wondering, was there any breaking change in this version? I only recently came to realise that rules for v0.x.y are slightly different from v1.x.y. For dependency declared as ^0.1.0, package managers will not install v0.2.0 even though they are the same major version.
Yeah, I moved webpack from dependencies to peerDependencies, because of #30.
I wasn't sure whether it's a breaking change or not, so I decided to go safe with this one.
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I moved webpack from dependencies to peerDependencies, because of #30.
I wasn't sure whether it's a breaking change or not, so I decided to go safe with this one.
Yea I saw that.. Looks absolutely great! I was wondering where I could mention that 😉
Do you think the changelog should call out possible breaking changes?
237f6db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @asfktz, I was just wondering, was there any breaking change in this version? I only recently came to realise that rules for
v0.x.y
are slightly different fromv1.x.y
. For dependency declared as^0.1.0
, package managers will not installv0.2.0
even though they are the same major version.237f6db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sudo-suhas,
Yeah, I moved webpack from
dependencies
topeerDependencies
, because of #30.I wasn't sure whether it's a breaking change or not, so I decided to go safe with this one.
I also maintain a CHANGELOG now.
237f6db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Makes sense.
Yea I saw that.. Looks absolutely great! I was wondering where I could mention that 😉
Do you think the changelog should call out possible breaking changes?
237f6db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree. I mention that it's a break change the way webpack's doing it, but it's not clear enough.