PR-6096: Upgrade to Python 3.10 #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjclark
force-pushed
the
gjc/upgrade/python
branch
from
3103734 to
4e250b6
Compare
mckadesorensen
force-pushed
the
gjc/upgrade/python
branch
from
62c760d to
69ed7ea
Compare
mckadesorensen
approved these changes
Sep 17, 2024
gjclark
force-pushed
the
gjc/upgrade/python
branch
from
043f110 to
9d441be
Compare
reweeden
reviewed
Sep 18, 2024
| @@ -71,7 +70,7 @@ all: build ; | |||
|
|
|||
| # Build everything | |||
| .PHONY: build | |||
| build: \ | |||
| build: tea-dependency-builder \ | |||
There was a problem hiding this comment.
I don't think this is desired, this will rebuild the docker image every time you run make build.
There was a problem hiding this comment.
BTW the GNU make documentation is pretty good:
https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html
There was a problem hiding this comment.
If there is nothing new with the dockerfile, it takes half a second to run that portion. I don't see an issue with that.
There was a problem hiding this comment.
Since we removed the line DOCKER_LAMBDA_CI = $(DOCKER_COMMAND) lambci/lambda:build-python3.8, and instead are using our own docker image, we need to build the docker image before we can run make build.
gjclark
force-pushed
the
gjc/upgrade/python
branch
from
c3466d1 to
6f7b500
Compare
reweeden
reviewed
Sep 19, 2024
gjclark
force-pushed
the
gjc/upgrade/python
branch
from
6f7b500 to
28bbd61
Compare
gjclark
changed the title
reweeden
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made the decision to go with Python 3.10. Python 3.10 works out of the box and 3.11+ had issues with
chalicethat were not extremely clear on how to fix.In
lint,test, andreleaseyml files I had to use python version 3.10.15 (latest ATM). Setting to 3.10 causes an error that other people are experiencing. Same error can be found here: actions/setup-python#401 (comment).