Skip to content

Commit

Permalink
feat: Use python3.9
Browse files Browse the repository at this point in the history
  • Loading branch information
gjclark committed Sep 11, 2024
1 parent ea53862 commit 3103734
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Makefile.config:
include Makefile.config

ifdef DOCKER_COMMAND
DOCKER_LAMBDA_CI = $(DOCKER_COMMAND) lambci/lambda:build-python3.8
DOCKER_LAMBDA_CI = $(DOCKER_COMMAND) lambci/lambda:build-python3.9
DOCKER_DEPENDENCY_BUILDER = $(DOCKER_COMMAND) tea-dependency-builder
endif

Expand Down
2 changes: 1 addition & 1 deletion README.MD
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ releases see the [GitHub Actions README](.github/workflows/README.md).*
In order to build TEA, you will need to have a few tools installed:

- `make` for build automation
- `python3.8` for running tests and creating the CloudFormation template
- `python3.9` for running tests and creating the CloudFormation template
- `docker` for building the dependency layer
- `git` for installing rain-api-core
- `zip` for creating zip files
Expand Down
2 changes: 1 addition & 1 deletion build/dependency_builder.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ mkdir -p $BUILD_DIR/python
cd $BUILD_DIR/python || exit

echo "Installing ${REQUIREMENTS_FILE}"
python3.8 -m pip install \
python3.9 -m pip install \
--upgrade \
-r "$REQUIREMENTS_FILE" \
--target $BUILD_DIR/python \
Expand Down
2 changes: 1 addition & 1 deletion build/lambda-ci.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
FROM lambci/lambda:build-python3.8
FROM lambci/lambda:build-python3.9

RUN pip install pip-tools
7 changes: 4 additions & 3 deletions cloudformation/thin-egress-app.yaml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ Resources:
vpcid: !Sub "${PrivateVPC}"
Timeout: !Ref LambdaTimeout
Handler: update_lambda.lambda_handler
Runtime: 'python3.8'
Runtime: 'python3.9'
Layers:
- !Ref EgressLambdaDependencyLayer
#MemorySize: 128
Expand Down Expand Up @@ -561,6 +561,7 @@ Resources:
- python3.6
- python3.7
- python3.8
- python3.9 # TODO (gjclark): Make sure that 3.8 and 3.9 do both work
Content:
S3Bucket: !Ref LambdaCodeS3Bucket
S3Key: !Ref LambdaCodeDependencyArchive
Expand Down Expand Up @@ -630,7 +631,7 @@ Resources:
OTEL_COLLECTOR_URL: !Ref OtCollectorURL
Timeout: !Ref LambdaTimeout
Handler: app.app
Runtime: 'python3.8'
Runtime: 'python3.9'
Layers:
- !Ref EgressLambdaDependencyLayer
- !Sub "arn:aws:lambda:${AWS::Region}:901920570463:layer:aws-otel-python38-ver-1-5-0:3"
Expand Down Expand Up @@ -1110,7 +1111,7 @@ Resources:
BUILD_VERSION: "{{ build_version }}"
MATURITY: !Ref Maturity
Handler: tea_bumper.lambda_handler
Runtime: 'python3.8'
Runtime: 'python3.9'
Layers:
- !Ref EgressLambdaDependencyLayer

Expand Down
2 changes: 1 addition & 1 deletion tests/test_tea_bumper.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def test_lambda(client_iam, client_lambda, test_lambda_code_zip):

client_lambda.create_function(
FunctionName="test-lambda",
Runtime="python3.8",
Runtime="python3.9",
Role=role["Arn"],
Code={
"ZipFile": b64encode(test_lambda_code_zip)
Expand Down

0 comments on commit 3103734

Please sign in to comment.