Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT script improvements #740

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added comment to ssh-keygen command
This makes keygen omit the hostname and use the provided comment instead.
benbart committed Aug 10, 2023

Verified

This commit was signed with the committer’s verified signature.
commit 565152963321c0906d64d882fb4bf2e892bca2da
2 changes: 1 addition & 1 deletion scripts/setup_jwt_cookie.sh
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ EOL

function GENERATE_TEA_CREDS {
cd /tmp || exit 1
ssh-keygen -t rsa -b 4096 -m PEM -f ./jwtcookie.key -N ''
ssh-keygen -t rsa -b 4096 -m PEM -f ./jwtcookie.key -N '' -C "asfjwt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about writing a complete sentence like 'A key used by Thin Egress App to sign JWTs'. I'm not sure we want to put ASF in there since this may be used by other DAACs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree about putting the ASF in there.

openssl base64 -in jwtcookie.key -out jwtcookie.key.b64 -A
openssl base64 -in jwtcookie.key.pub -out jwtcookie.key.pub.b64 -A