JWT script improvements #740
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes keygen omit the hostname and use the provided comment instead.
gjclark
approved these changes
Aug 10, 2023
reweeden
reviewed
Aug 10, 2023
scripts/setup_jwt_cookie.sh
Outdated
| @@ -14,7 +14,7 @@ EOL | |||
|
|
|||
| function GENERATE_TEA_CREDS { | |||
| cd /tmp || exit 1 | |||
| ssh-keygen -t rsa -b 4096 -m PEM -f ./jwtcookie.key -N '' | |||
| ssh-keygen -t rsa -b 4096 -m PEM -f ./jwtcookie.key -N '' -C "asfjwt" | |||
There was a problem hiding this comment.
How about writing a complete sentence like 'A key used by Thin Egress App to sign JWTs'. I'm not sure we want to put ASF in there since this may be used by other DAACs.
There was a problem hiding this comment.
I agree about putting the ASF in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.