Restructure workflows #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabuelhagag
added a commit
that referenced
this pull request
Aug 9, 2022
- Python version upgraded in Dockerfiles - Upgraded requirements - Moved management CLI commands from `manage.py` that uses click to `actions.py` that uses [Flask's CLI custom commands](https://flask.palletsprojects.com/en/2.2.x/cli/#custom-commands) as [flask-scripts is now deprecated](https://github.com/smurfix/flask-script#deprecated). - Moved `create_app()` to `__init__` to fix cyclical import error - CI/CD - Disabled CD of the server. - Disable some integration tests as they were failing on live testing (to be reviewed later). - Used `docker compose` command instead of `docker-compose` command as it fails on newer versions of Docker. - Build Azure Service bus credentials without URL-encode them as it's handled in Kombu. encoding them caused the live test to fail when Celery was trying to connect. - Running `register_client` celery task asynchronously caused the tests to report false success results. So now it's called synchronously (to be further investigated later) - Migrated to `ServiceBusAdministrationClient` in `delete_queues` cli command. See [migration guide](https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/servicebus/azure-servicebus/migration_guide.md#working-with-administration-client). - Other changes done in #597 - Removed the usage of `autoescape` and `with_` Jinja extensions as they're now already included in the compiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.