Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra line endings inserted when editing Simplenote text #144

Closed
ddirks opened this issue Aug 16, 2020 · 2 comments · Fixed by #145
Closed

Extra line endings inserted when editing Simplenote text #144

ddirks opened this issue Aug 16, 2020 · 2 comments · Fixed by #145
Labels

Comments

@ddirks
Copy link

ddirks commented Aug 16, 2020

This is a follow-on to a bunch of issues recently fixed and closed, including:

and may be related to an issue I originally (mistakenly) reported on withExEditorHost regarding behavior when using the external editor with Simplenote:

Currently I am looking at withExEditor 5.4.4 on Windows 64-bit. The behavior I see when editing a Simplenote note is that when I invoke the editor (gvim), extra newlines are inserted in the editor window, one extra newline per original line. The additional newlines are preserved when the text is re-inserted into the browser window. This is different from what happened when I originally reported the issue; in that issue, lines were entered into the editor window properly, but newlines were added when the text was re-inserted into the original browser window.

I see this behavior with Simplenote notes in both Firefox and Chrome.

I do not see the extra lines inserted when editing text from other web apps (I tested yahoo mail, gmail, todoist).

Thanks for all your work on this -- it appears to have been very complicated to untangle!

@asamuzaK asamuzaK added the bug label Aug 17, 2020
asamuzaK added a commit that referenced this issue Aug 18, 2020
Fix #144
Part 1. basic refactoring
@asamuzaK
Copy link
Owner

@ddirks
Released withExEditor v7.1.4 couple days ago.
Is it working as expected now?

@ddirks
Copy link
Author

ddirks commented Aug 27, 2020

Yes! The withExEditor/gvim/Simplenote web combination is once again working for me, under both Firefox and Chrome. (Win10x64)

Thank you so much for working through all these issues...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants