Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using external editor causes Simplenote to hang #77

Closed
ddirks opened this issue Feb 14, 2020 · 5 comments
Closed

Using external editor causes Simplenote to hang #77

ddirks opened this issue Feb 14, 2020 · 5 comments

Comments

@ddirks
Copy link

ddirks commented Feb 14, 2020

For some time, I have used the withExEditorHost to launch gVim from Firefox (Windows 10 Pro). Recently, I have noticed that when editing a note in the Simplenote web interface, when gVim closes the Simplenote text is updated, but with extra linefeeds (or maybe it's \cr\lf instead of just \cr -- I'm not sure), and the Simplenote site itself becomes unresponsive. The edited note is no longer saved as expected.

I have no idea if this change in behavior occurred due to a change in the withExEditorHost, a change in the Simplenote web interface, or something unrelated to either of them, like a change in Windows. I see the same behavior on several Windows machines, some at my office and some at home, so it doesn't appear to be a specific security setting for firewall issue.

I'm starting here because the withExEditorHost seems to change more often than Simplenote (as far as I can tell.)

Thanks for any ideas or suggestions regarding how I can try to debug the situation.

I've attached a text file with the errors that show up in the browser console after exiting gVim.

simplenote_withExEditor_error.txt

@asamuzaK
Copy link
Owner

Simplenote is a React app, and React uses Draft.js for text editor.
But withExEditor currently does not support Draft.js.

Follow asamuzaK/withExEditor#123

@ddirks
Copy link
Author

ddirks commented Feb 18, 2020

Thanks for the explanation. I'll keep an eye on the issue you mentioned.

@asamuzaK
Copy link
Owner

@ddirks
asamuzaK/withExEditor#123 is fixed on Blink (Chrome and its variants).
Can you check if it works or not on Simplenote with Chrome?

@ddirks
Copy link
Author

ddirks commented Jul 31, 2020

I just installed withExEditor in Chrome (ver 84.0.4147.105, 64-bit Windows 10), and it does in fact work with Simplenote! Thanks for that!

As you're no doubt aware, the behavior in Firefox has evolved since the original report back in February. Now, when I edit a Simplenote page with the external editor, closing the editor simply doesn't change the original Simplenote text. I see asamuzaK/withExEditor#138 seems to be addressing exactly that.

For reference, I have withExEditorHost v. 5.4.3 installed.

@asamuzaK
Copy link
Owner

asamuzaK commented Aug 1, 2020

Thanks.

This issue is not a host issue so I'll close here.
Please follow asamuzaK/withExEditor#138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants