Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRC-2420 Security audit and package updates #372

Merged
merged 11 commits into from
Jul 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ module.exports = {
"preact",
"plugin:@typescript-eslint/eslint-recommended",
"plugin:@typescript-eslint/recommended",
"plugin:cypress/recommended",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a plugin we've had as a dependency for a long while, but it wasn't being used.

],
plugins: ["@typescript-eslint"],
rules: {
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.17.2] - 2023-07-11

### Security

- Dependency Updates and Security Audit

## [1.17.1] - 2023-05-30

### Security
Expand Down
3 changes: 3 additions & 0 deletions cypress/e2e/auto-destroy.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ describe("Auto-Destroy", () => {
});
cy.get("#meridian-map").should("not.exist");
// Wait for the auto-destroy polling (1 second interval)
// eslint-disable-next-line cypress/no-unnecessary-waiting
cy.wait(1200);
getMeridianMap().then((meridianMap) => {
expect(onDestroyStub).callCount(1);
Expand All @@ -39,6 +40,7 @@ describe("Auto-Destroy", () => {
});
});
// Wait for MeridianMap to be rendered...
// eslint-disable-next-line cypress/no-unnecessary-waiting
cy.wait(500);
cy.window().should((win) => {
const mapContainer = win.document.querySelector("#meridian-map");
Expand All @@ -50,6 +52,7 @@ describe("Auto-Destroy", () => {
// Check that the map container's contents have been deleted
cy.get(".meridian-map-container").should("not.exist");
// Wait for the auto-destroy polling (1 second interval)
// eslint-disable-next-line cypress/no-unnecessary-waiting
cy.wait(1200);
getMeridianMap().then((meridianMap) => {
expect(onDestroyStub).callCount(1);
Expand Down
3 changes: 2 additions & 1 deletion cypress/e2e/basic.cy.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
describe("Basic", () => {
// eslint-disable-next-line jest/valid-describe-callback
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was failing a lint check because it was treated like a jest describe where the second argument can only be a function.

describe("Basic", { testIsolation: false }, () => {
before(() => {
cy.visit("/cypress/basic");
});
Expand Down
Loading