MRC-2420 Security audit and package updates #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vercasson
commented
Jul 10, 2023
•
vercasson
commented
- This change is documented in CHANGELOG.md
vercasson
commented
Jul 10, 2023
| @@ -1,4 +1,5 @@ | |||
| describe("Basic", () => { | |||
| // eslint-disable-next-line jest/valid-describe-callback | |||
There was a problem hiding this comment.
This was failing a lint check because it was treated like a jest describe where the second argument can only be a function.
vercasson
commented
Jul 10, 2023
| @@ -12,6 +12,7 @@ module.exports = { | |||
| "preact", | |||
| "plugin:@typescript-eslint/eslint-recommended", | |||
| "plugin:@typescript-eslint/recommended", | |||
| "plugin:cypress/recommended", | |||
There was a problem hiding this comment.
This is a plugin we've had as a dependency for a long while, but it wasn't being used.
amyhliao
approved these changes
Jul 10, 2023
tarakreft
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.