Squash on green (again) #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay so this is failing in the weirdest way. The process of applying the Squash on Green label was failing in Danger's Looks like we were hitting this bug, which has been fixed in Danger already (but we're on an older version): danger/danger-js#1020 Basically we weren't paginating through all the labels on a repo, so it didn't see the (most-recently created) "Squash on Green" label already existed. I deleted some unused labels in Eigen and it's working now 🎉 I will ask for a pairing partner on Monday's standup to upgrade to the latest Danger, which should solve this problem generally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor to #161 and #164. I'm self-assigning so I can monitor once merged /cc @jonallured
The important change is in 83f950f.