Squash on Green

[ashfurrow]

This PR re-applies the work from #161 (reverting #163) and fixing the syntax issue that caused the revert in the first place in b366023. I pinned the TypeScript version to what's actually used by Peril to avoid this kind if unsupported-syntax-error from happening in the future.

[jonallured]

LGTM!! 🎉

[jonallured]

question [non-blocking]: typescript version pin

This is the pin you mentioned? Couldn't one clobber this with yarn upgrade --latest? Is there another, more resilient way to specify which version of a package one wants? 🤔

format via Conventional Comments

[ashfurrow]

This is the pin, I'm not sure about the semantics of yarn upgrade – I'm basing this off Renovate's PRs to pin dependencies in Eigen, which follow this format. (Previously, in c2cdda6, this was at 4.0.2.)

[ashfurrow]

Ugh! Still seeing a failure:

2020-09-11T19:03:11.993343+00:00 app[web.1]: Fri, 11 Sep 2020 19:03:11 GMT runFromSameHost Unable to evaluate the Dangerfile
2020-09-11T19:03:11.993345+00:00 app[web.1]:  TypeError: Cannot convert undefined or null to object
2020-09-11T19:03:11.993347+00:00 app[web.1]:     at Function.values (<anonymous>)
2020-09-11T19:03:11.993348+00:00 app[web.1]:     at Object.exports.rfc10 (peril-downloaded-artsy/peril-settings@org/mergeOnGreen.ts:26:35)
2020-09-11T19:03:11.993349+00:00 app[web.1]:     at process._tickCallback (internal/process/next_tick.js:68:7)

I'll have to look into this later, sorry for the noise Jon!

[jonallured]

Oh bummer - no problem though we can totally come back to this. Monday Ash is going to crush it!! ❤️

[ashfurrow]

My guess is that the relative import between files isn't setup right (because of how Peril executes things). Other relative imports do a weird await import dance that we need to replicate.