-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Banner component with Sign up and Log in buttons for m… #7644
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ca2e09b
draft: Created Banner component with Sign up and Log in buttons for m…
d75e508
Showing banner for not logged in users and on mobile only
81373fb
Added more space above content in order to make banner fit
ee48573
Class components replaced with function components
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import React from "react" | ||
import { Flex, color } from "@artsy/palette" | ||
import { BannerButton } from "./Button" | ||
import styled from "styled-components" | ||
|
||
interface Props {} | ||
|
||
const Container = styled(Flex)` | ||
width: 100%; | ||
padding: 12px; | ||
background-color: ${color("black100")}; | ||
` | ||
|
||
export class Banner extends React.Component<Props> { | ||
render() { | ||
return ( | ||
<Container> | ||
<BannerButton href="/sign_up" marginRight="12px"> | ||
Sign up | ||
</BannerButton> | ||
<BannerButton href="/log_in">Log in</BannerButton> | ||
</Container> | ||
) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import React from "react" | ||
import { Box, color, BoxProps } from "@artsy/palette" | ||
import { RouterLink } from "v2/Artsy/Router/RouterLink" | ||
import styled from "styled-components" | ||
|
||
interface Props extends BoxProps { | ||
href: string | ||
} | ||
|
||
const Button = styled(Box).attrs({ | ||
flexGrow: 1, | ||
py: "8px", | ||
})` | ||
width: 50%; | ||
height: 40px; | ||
text-align: center; | ||
background-color: ${color("black80")}; | ||
color: ${color("white100")}; | ||
font-family: "ll-unica77", "Helvetica Neue", Helvetica, Arial, sans-serif; | ||
font-weight: bold; | ||
font-size: 15px; | ||
` | ||
dzucconi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
export class BannerButton extends React.Component<Props> { | ||
render() { | ||
const { href, children, ...rest } = this.props | ||
|
||
return ( | ||
<Button {...rest}> | ||
<RouterLink to={href} noUnderline> | ||
{children} | ||
</RouterLink> | ||
</Button> | ||
) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
export * from "./Banner" | ||
export * from "./Button" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use React function components instead of classes? (All class use should be considered depreciated, since we can't combine classes and react hooks)