Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Banner component with Sign up and Log in buttons for m… #7644

Merged
merged 4 commits into from
May 28, 2021

Conversation

anastasiapyzhik
Copy link
Contributor

@anastasiapyzhik anastasiapyzhik commented May 27, 2021

…obile

Before
Screen Shot 2021-05-27 at 5 41 34 PM

After
Screen Shot 2021-05-27 at 5 42 15 PM

@anastasiapyzhik anastasiapyzhik requested a review from a team May 27, 2021 13:14
@anastasiapyzhik anastasiapyzhik force-pushed the anastasiapyzhik/add-auth-banners-on-mobile branch from 0cef62f to ca2e09b Compare May 27, 2021 13:26
@anastasiapyzhik anastasiapyzhik changed the title draft: Created Banner component with Sign up and Log in buttons for m… Created Banner component with Sign up and Log in buttons for m… May 27, 2021
background-color: ${color("black100")};
`

export class Banner extends React.Component<Props> {
Copy link
Member

@damassi damassi May 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use React function components instead of classes? (All class use should be considered depreciated, since we can't combine classes and react hooks)

Copy link
Member

@damassi damassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 👍 One request about swapping a class component for a react function component however

@damassi damassi merged commit 70b2037 into master May 28, 2021
@damassi damassi deleted the anastasiapyzhik/add-auth-banners-on-mobile branch May 28, 2021 16:34
@artsy-peril artsy-peril bot mentioned this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants