Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] MPP No Trace & Improve debugging experience of leaked raise calls #2923

Merged
merged 9 commits into from
Feb 9, 2023

Conversation

nomisRev
Copy link
Member

@nomisRev nomisRev commented Feb 8, 2023

@nomisRev nomisRev added the 1.2.0 Tickets belonging to 1.1.2 label Feb 8, 2023
@nomisRev nomisRev requested review from serras, raulraja, franciscodr and a team February 8, 2023 09:32
Copy link
Member

@serras serras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

My only concern is that we break binary compatibility from the previous commit, but I guess this is OK since this code was never released out of alpha versions

Copy link
Collaborator

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nomisRev

@nomisRev
Copy link
Member Author

nomisRev commented Feb 9, 2023

but I guess this is OK since this code was never released out of alpha versions

Yes, it's only important between stable versions.

@nomisRev nomisRev merged commit 08c7d49 into main Feb 9, 2023
@nomisRev nomisRev deleted the sv-backport-raise-fixes branch February 9, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.2.0 Tickets belonging to 1.1.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants