-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] MPP No Trace & Improve debugging experience of leaked raise calls #2923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
My only concern is that we break binary compatibility from the previous commit, but I guess this is OK since this code was never released out of alpha
versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @nomisRev
Yes, it's only important between stable versions. |
ShiftLeakedException
to improve the debug experience, this PR applies it to Backport Raise & error handlers #2912.shift
, this PR applies it to Backport Raise & error handlers #2912.result
behavior fromarrow.core.continuations
where unexpectedThrowable
is also mapped toResult.failure
.