Backport Raise & error handlers #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscodr
reviewed
Jan 31, 2023
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/raise/Raise.kt
Outdated
Show resolved
Hide resolved
franciscodr
reviewed
Jan 31, 2023
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/raise/Raise.kt
Outdated
Show resolved
Hide resolved
franciscodr
reviewed
Jan 31, 2023
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/raise/Raise.kt
Outdated
Show resolved
Hide resolved
franciscodr
reviewed
Jan 31, 2023
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/raise/Raise.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Francisco Diaz <[email protected]>
😭 |
nomisRev
changed the title
|
@serras can you please pay special attention to the contracts that I didn't forget anything 😅 🙏 |
serras
approved these changes
Feb 5, 2023
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Either.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration Guide
See two proposal migration guides for
Either&Effect.Using
EitherReplace
either { }
arrow.core.continuations.either->arrow.core.raise.eitherarrow.core.continuations.ensureNotNull->arrow.core.raise.ensureNotNullarrow.core.computations.either->arrow.core.raise.eitherarrow.core.computations.ensureNotNull->arrow.core.raise.ensureNotNull
Replace
either.eager { }
arrow.core.continuations.either.eager->arrow.core.raise.either=> Might introduce duplicate import for
arrow.core.raise.eithereither.eager {->either {
Replace
EffectScope/EagerEffectScope
arrow.core.continuations.EffectScope->arrow.core.raise.Raisearrow.core.continuations.EagerEffectScope->arrow.core.raise.Raisearrow.core.continuations.ensureNotNull->arrow.core.raise.ensureNotNull
Using
Effect
arrow.core.continuations.Effect->arrow.core.raise.Effectarrow.core.continuations.ensureNotNull->arrow.core.raise.ensureNotNull
=> Requires manually adding missing imports for
fold, error handlers, and allEffectmethods since they're replaced by extension functions.
Using
EagerEffect
arrow.core.continuations.EagerEffect->arrow.core.raise.EagerEffectarrow.core.continuations.ensureNotNull->arrow.core.raise.ensureNotNull
=> Requires manually adding missing imports for
fold, error handlers, and allEagerEffectmethods since they're replaced by extension functions.