Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate optics based on targets or all #2683

Merged
merged 4 commits into from
Mar 10, 2022
Merged

generate optics based on targets or all #2683

merged 4 commits into from
Mar 10, 2022

Conversation

i-walker
Copy link
Member

@i-walker i-walker commented Mar 9, 2022

resolves #2657

Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nomisRev nomisRev merged commit 28fea1c into main Mar 10, 2022
@nomisRev nomisRev deleted the is-optics-target-fix branch March 10, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

["BUG"] arrow-optics-ksp-plugin doesn't respect target parameter in @optics annotation
2 participants