fix: Add liveness and readiness probes #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Parraga <[email protected]>
dejanzele
reviewed
Nov 21, 2024
Signed-off-by: Jason Parraga <[email protected]>
Sovietaced
commented
Nov 23, 2024
| @@ -274,10 +275,12 @@ func (r *ExecutorReconciler) createDeployment( | |||
| ImagePullPolicy: corev1.PullIfNotPresent, | |||
| Image: ImageString(executor.Spec.Image), | |||
| Args: []string{appConfigFlag, appConfigFilepath}, | |||
| Ports: newContainerPortsMetrics(config), | |||
| Ports: newContainerPortsHTTPWithMetrics(config), | |||
There was a problem hiding this comment.
This is a bug fix since the executor does have an HTTP server.
Sovietaced
commented
Nov 23, 2024
| @@ -314,10 +315,12 @@ func newSchedulerDeployment( | |||
| ImagePullPolicy: corev1.PullIfNotPresent, | |||
| Image: ImageString(scheduler.Spec.Image), | |||
| Args: []string{"run", appConfigFlag, appConfigFilepath}, | |||
| Ports: newContainerPortsGRPCWithMetrics(config), | |||
| Ports: newContainerPortsAll(config), | |||
There was a problem hiding this comment.
Another bug fix since the scheduler has all the ports.
Sovietaced
commented
Nov 23, 2024
Sovietaced
commented
Nov 23, 2024
Sovietaced
commented
Nov 23, 2024
| @@ -371,6 +380,36 @@ func createEnv(crdEnv []corev1.EnvVar) []corev1.EnvVar { | |||
| return envVars | |||
| } | |||
|
|
|||
| func CreateProbesWithScheme(scheme corev1.URIScheme) (*corev1.Probe, *corev1.Probe) { | |||
There was a problem hiding this comment.
The values here are pretty standardized for now but we might want to support customization later.
There was a problem hiding this comment.
Yeah, seems good enough for starters.
dejanzele
reviewed
Nov 25, 2024
Signed-off-by: Jason Parraga <[email protected]>
Sovietaced
force-pushed
the
issue-334
branch
from
84b45bd to
90e9d45
Compare
dejanzele
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pull request updates various controllers to add readiness & liveness probes to containers where applicable. These probes should help indicate when it is safe to cutover to new deployments.
I cross referenced https://github.com/armadaproject/armada/tree/master/deployment (I may have found some bugs in here tho) as well as each application's config structs to understand which ports they expose.
Fixes #334
Type of change
Please select the type of change your PR introduces:
How Has This Been Tested?
Added unit tests to assert the fully generated deployment with probes.
Checklist: