Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller should include readiness/liveness checks in deployments #334

Closed
Sovietaced opened this issue Nov 16, 2024 · 1 comment · Fixed by #339
Closed

Controller should include readiness/liveness checks in deployments #334

Sovietaced opened this issue Nov 16, 2024 · 1 comment · Fixed by #339

Comments

@Sovietaced
Copy link
Contributor

I don't believe the controller includes readiness/lives checks on any of the deployments which seems important. We are having a production issue where lookout stops accepting TCP connections and this would likely have been discovered by a liveness check.

I should have a pull request up in the next week to add support for this.

@dejanzele
Copy link
Member

Yes, definitely, we need liveness/readiness checks.

Not all Armada components exposed healthcheck routes before, but a lot of things have progressed.

The Helm charts (https://github.com/armadaproject/armada/tree/master/deployment) should accuratelly reflect what is supported, and the Operator should follow changes to the Helm charts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants