Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MSM: Use VariableBaseMSM trait #425

Merged
merged 22 commits into from
Jun 30, 2022

Commits on Jun 3, 2022

  1. Configuration menu
    Copy the full SHA
    f1d8c46 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    21e694c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ad0f704 View commit details
    Browse the repository at this point in the history
  4. disambiguate calls

    mmagician committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    97f9214 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1408ca6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    58fee09 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f46cbfd View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5e3ad28 View commit details
    Browse the repository at this point in the history
  9. fix formatting

    mmagician committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    6c092a7 View commit details
    Browse the repository at this point in the history
  10. Update CHANGELOG.md

    mmagician committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    574ca9c View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    bc30532 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Change defaults for VariableBaseMSM.

    The default, user-friendly way is to multiply group elements by elements
    in the scalar field. In an attempt to add some ergonomics,
    I'm using the same template but for scalars and adding a big fat warning
    that no checks is performed on the size.
    
    The function that acts immediately on the bigints can also be called
    explicitly if the caller knows that the same scalar vectors will be used
    multiple times. Note that copying that vector only buys a few ms per
    MSM of 2^20 elements or more.
    The extra function `msm_bigint` also allows to perform  optimizations
    on `msm` before the call to `msm_bigint`: instead of
    normalizing into `BigInt`s with `u64` we can move to `i32` and use half the
    number of buckets in Pippenger, exploiting group addition,
    using the representation in buckets as [-w/2 + 1, w/2] instead of [0, w-1].
    
    Use the frontend API `VariableBaseMSM::msm` in tests when possible.
    
    Change (again) defaults for VariableBaseMSM not to panic.
    
    After asking around, looks like most people assume that there is no bound
    check (e.g. when committing to a vector or a polynomial). I'm therefore
    reverting the change on the bound check
    mmaker committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    e5bfe79 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    288667f View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Merge pull request #14 from mmaker/fix/425

    Fix/425
    mmagician authored Jun 15, 2022
    Configuration menu
    Copy the full SHA
    8cced93 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Address Pratyush's comments for arkworks-rs#425 in VariableBaseMSM.

    Prefix `add_assign_mixed` and `double_in_place` with underscore and
    hide from documentation.
    mmaker authored and mmagician committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    27b9e15 View commit details
    Browse the repository at this point in the history
  2. Fix formatting

    mmagician committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    73065ac View commit details
    Browse the repository at this point in the history
  3. Revert fixed_base changes for now

    Co-Authored-By: Michele Orrù <[email protected]>
    mmagician and mmaker committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    c02bd9f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3a5075a View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. Update CHANGELOG.md

    Co-authored-by: Michele Orrù <[email protected]>
    mmagician and mmaker authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    996a69a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82cf15f View commit details
    Browse the repository at this point in the history
  3. Fix documentation for VariableBaseMSM.

    mmaker authored and mmagician committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    f11be6f View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Configuration menu
    Copy the full SHA
    74c95c2 View commit details
    Browse the repository at this point in the history