-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor MSM: Use VariableBaseMSM
trait
#425
Merged
Merged
Commits on Jun 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f1d8c46 - Browse repository at this point
Copy the full SHA f1d8c46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21e694c - Browse repository at this point
Copy the full SHA 21e694cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad0f704 - Browse repository at this point
Copy the full SHA ad0f704View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97f9214 - Browse repository at this point
Copy the full SHA 97f9214View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1408ca6 - Browse repository at this point
Copy the full SHA 1408ca6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58fee09 - Browse repository at this point
Copy the full SHA 58fee09View commit details -
Configuration menu - View commit details
-
Copy full SHA for f46cbfd - Browse repository at this point
Copy the full SHA f46cbfdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e3ad28 - Browse repository at this point
Copy the full SHA 5e3ad28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c092a7 - Browse repository at this point
Copy the full SHA 6c092a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 574ca9c - Browse repository at this point
Copy the full SHA 574ca9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc30532 - Browse repository at this point
Copy the full SHA bc30532View commit details
Commits on Jun 10, 2022
-
Change defaults for VariableBaseMSM.
The default, user-friendly way is to multiply group elements by elements in the scalar field. In an attempt to add some ergonomics, I'm using the same template but for scalars and adding a big fat warning that no checks is performed on the size. The function that acts immediately on the bigints can also be called explicitly if the caller knows that the same scalar vectors will be used multiple times. Note that copying that vector only buys a few ms per MSM of 2^20 elements or more. The extra function `msm_bigint` also allows to perform optimizations on `msm` before the call to `msm_bigint`: instead of normalizing into `BigInt`s with `u64` we can move to `i32` and use half the number of buckets in Pippenger, exploiting group addition, using the representation in buckets as [-w/2 + 1, w/2] instead of [0, w-1]. Use the frontend API `VariableBaseMSM::msm` in tests when possible. Change (again) defaults for VariableBaseMSM not to panic. After asking around, looks like most people assume that there is no bound check (e.g. when committing to a vector or a polynomial). I'm therefore reverting the change on the bound check
Configuration menu - View commit details
-
Copy full SHA for e5bfe79 - Browse repository at this point
Copy the full SHA e5bfe79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 288667f - Browse repository at this point
Copy the full SHA 288667fView commit details
Commits on Jun 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8cced93 - Browse repository at this point
Copy the full SHA 8cced93View commit details
Commits on Jun 21, 2022
-
Address Pratyush's comments for arkworks-rs#425 in VariableBaseMSM.
Prefix `add_assign_mixed` and `double_in_place` with underscore and hide from documentation.
Configuration menu - View commit details
-
Copy full SHA for 27b9e15 - Browse repository at this point
Copy the full SHA 27b9e15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73065ac - Browse repository at this point
Copy the full SHA 73065acView commit details -
Revert fixed_base changes for now
Co-Authored-By: Michele Orrù <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c02bd9f - Browse repository at this point
Copy the full SHA c02bd9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a5075a - Browse repository at this point
Copy the full SHA 3a5075aView commit details
Commits on Jun 27, 2022
-
Co-authored-by: Michele Orrù <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 996a69a - Browse repository at this point
Copy the full SHA 996a69aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82cf15f - Browse repository at this point
Copy the full SHA 82cf15fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f11be6f - Browse repository at this point
Copy the full SHA f11be6fView commit details
Commits on Jun 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 74c95c2 - Browse repository at this point
Copy the full SHA 74c95c2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.