Fix/425 #14
Merged
Fix/425 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default, user-friendly way is to multiply group elements by elements in the scalar field. In an attempt to add some ergonomics, I'm using the same template but for scalars and adding a big fat warning that no checks is performed on the size. The function that acts immediately on the bigints can also be called explicitly if the caller knows that the same scalar vectors will be used multiple times. Note that copying that vector only buys a few ms per MSM of 2^20 elements or more. The extra function `msm_bigint` also allows to perform optimizations on `msm` before the call to `msm_bigint`: instead of normalizing into `BigInt`s with `u64` we can move to `i32` and use half the number of buckets in Pippenger, exploiting group addition, using the representation in buckets as [-w/2 + 1, w/2] instead of [0, w-1]. Use the frontend API `VariableBaseMSM::msm` in tests when possible. Change (again) defaults for VariableBaseMSM not to panic. After asking around, looks like most people assume that there is no bound check (e.g. when committing to a vector or a polynomial). I'm therefore reverting the change on the bound check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to arkworks-rs#425 (comment)