Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename BigInteger::add_nocarry and sub_noborrow and add tests #383

Merged
merged 6 commits into from
Feb 1, 2022
Merged

Rename BigInteger::add_nocarry and sub_noborrow and add tests #383

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
da35ef7
Rename BigInteger add_nocarry to add_with_carry and sub_noborrow to s…
alexander-zw Jan 31, 2022
145b37e
Add more assertions regarding the carry/borrow bit in bigint tests
alexander-zw Jan 31, 2022
1d8a7a3
Add tests for big integer multiplication
alexander-zw Jan 31, 2022
0058e27
Update changelog breaking change
alexander-zw Jan 31, 2022
568f483
Reconcile with new changes on master
alexander-zw Feb 1, 2022
85a610d
Tweak Documentation
Pratyush Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ff/src/biginteger/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,8 @@ pub trait BigInteger:
/// Number of 64-bit limbs representing `Self`.
const NUM_LIMBS: usize;

/// Mutably add another bigint representation to this one, returning the carry bit.
/// Add another [`BigInteger`] to `self`. This method stores the result in `self`,
/// and returns a carry bit.
/// # Example
///
/// ```
Expand All @@ -721,7 +722,8 @@ pub trait BigInteger:
/// ```
fn add_with_carry(&mut self, other: &Self) -> bool;

/// Mutably subtract another bigint representation from this one, returning
/// Subtract another [`BigInteger`] from this one. This method stores the result in
/// `self`, and returns a borrow.
/// the borrow bit.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh typo?

/// # Example
///
Expand Down