Rename BigInteger::add_nocarry and sub_noborrow and add tests #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-zw
added
breaking-change
alexander-zw
force-pushed
the
rename-bigint
branch
from
85caab7
to
0058e27
Compare
Pratyush
reviewed
Feb 1, 2022
Pratyush
reviewed
Feb 1, 2022
Pratyush
approved these changes
Feb 1, 2022
alexander-zw
commented
Feb 5, 2022
| @@ -721,7 +722,8 @@ pub trait BigInteger: | |||
| /// ``` | |||
| fn add_with_carry(&mut self, other: &Self) -> bool; | |||
|
|
|||
| /// Mutably subtract another bigint representation from this one, returning | |||
| /// Subtract another [`BigInteger`] from this one. This method stores the result in | |||
| /// `self`, and returns a borrow. | |||
| /// the borrow bit. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BigInteger::add_nocarrytoadd_with_carryandsub_noborrowtosub_with_borrow.I did not rename the functions in arithmetic.rs, because those functions seem to actually ignore the carry and borrow bits.
closes: #335, #336
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer