New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serialization for Rc #153

Merged

weikengchen merged 2 commits into master from serialization-rc

Dec 21, 2020

Member

weikengchen commented Dec 21, 2020 •

edited

Loading

Description

This PR adds serialization for Rc<T>.

And also, it lets the Dummy serialization tests' serialize_uncompressed and serialize_unchecked use the underlying methods, so it closes #152.

Targeted PR against correct branch (main)
Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
Wrote unit tests
Updated relevant documentation in the code
Added a relevant changelog entry to the Pending section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

weikengchen added 2 commits

December 20, 2020 23:23


          Add serialization for Rc; update the Dummy serialization test

80ffd8c


          update the CHANGELOG

d6559fb

Pratyush approved these changes

View reviewed changes

weikengchen merged commit e00e554 into master

weikengchen deleted the serialization-rc branch

December 21, 2020 09:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet