Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialize tests Dummy is poorly written #152

Closed
jon-chuang opened this issue Dec 21, 2020 · 2 comments · Fixed by #153
Closed

serialize tests Dummy is poorly written #152

jon-chuang opened this issue Dec 21, 2020 · 2 comments · Fixed by #153

Comments

@jon-chuang
Copy link
Contributor

By not serializing to the actual type, it fails certain invariants, such as the fact that default impls for methods rely on other methods (such as uncompressed, unchecked). It is of questionable utility.

@weikengchen
Copy link
Member

I agree that its serialize_uncompressed and serialize_unchecked should use the [u8]'s serialize_uncompressed and serialize_unchecked.

Let me do it in an upcoming PR.

@jon-chuang
Copy link
Contributor Author

Actually I noticed my actual issue was something to do with the old serialized_unchecked being actually uncompressed. I fixed it in a forthcoming update to #130.

I guess morally speaking, what it is doing makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants