Pact of Umar

[Libeccio-DD]

Because muslim countries that get released or created over the course of the game or muslim countries that start with only muslim pops but later acquire territory with non-muslim pops, don't have the jizya modifier, I added an event that gives them the modifier.

[arkhometha]

Hi @Libeccio-DD, thanks for spotting this. While you are right about this, the approach is non-ideal: events tend to be more resource intensive, since the game needs to constantly check if the event is ready to fire. I know, it's just one event, but I prefer to do this kind of "clean up" as decisions to avoid a pile up of things. I integrated your pull through a decision that already exists and I'm pushing it in commit adc9fc3

[Libeccio-DD]

Hey @arkhometha, originally I created a decision that dealt with this problem but the reason for creating an event instead was because while the AI would always take such decision, the player could simply refuse to take it. The way you created the Pact of Umar is that any country that has the umar_pact flag and has non-muslim pops, should have the the jizya modifier. Then if the country doesn't want the modifier anymore they can take the secularize_society or abolish_umar_pact decisions. If however the player has both the umar_pact and non-muslim pops but doesn't take the decision that gives him the jizya modifier, I see it as unintended behaviour. This is not what is supposed to happen. My original plan to deal with this had this problem and your recent commit has this problem as well. I also think that it's quite inelegant that the decision that gives the jizya modifier has unrelated title, description, image and effect.

However there's a much better solution that deals with the aforementioned problem, doesn't create a new decision or event and is taken by the AI only. See more here #93.