Gfx life rating visual scale reduced by half and fixed vanilla needs meter graphical glitch #107
Conversation
…meter graphical glitch To improve the visualization of life rating on the province's screen, the scale of the gfx was reduced by half, with 50 being the maximum. (Using the same trick, it is also possible to show a scale of 0-10 life_rating, which would be better in my opinion, but it is necessary to test effects on migration and pop grow.) A vanilla visual glitch in the needs meter was also fixed. The 'progress.fx' function cuts a line of pixels after processing the sprite, perhaps due to rounding error. Reduced and lightened beer foam, TGA transparency of the wine glass has been corrected.
There was a problem hiding this comment.
Hi @thiagodesacosta, thanks for the commit. Great work fixing the LR scale and the visual glitches in the icons.
Regarding the Life Rating rework of the scale, that is something that is planned. After 45 LR bugs and doesn't give any more pop growth, but if the base LR that affects pop growth was 20 this bug wouldn't happen. At some point I'd like to stop healthcare reforms being a global flat modifier and make them affect only states, not colonies. To do that I will need to use LR and consequentially reduce its scale. The problem is, it's a monumental work - what needs to be changed is not only each LR for all provinces (easy part), but all events and decisions that change LR. It all needs to be made so the effects reflect the current scale.
So at some point the LR scale will be reduced, just don't know when.
* Fixed to Welsh Liberal party early end date. From #97 by @Libeccio-DD * Tweaks for the Zanzibar cores #101 and Alaskan Frontier decision #102 by @Libeccio-DD * Fixes to the Life Rating visual scale and to several graphics #107 by @thiagodesacosta * Fixes for potential problems if a country was somehow stuck with the lacks_writing_system modifier by @moretrim - #105 * Fix Fort position in Niigata so they do not overlap with Sado. Closes #104 * Fix for Greater Germany events not distributing provinces to existing countries - they will do it now. Made a few tweaks to the order of the released countries. If Austria has Bohemia/Sudetes/Lower Silesia cores when the event fires, Germany should get these as cores (and inherit them). Again, this is all a temporary solution until I fix the mess over Austrian cores. Closes #108 * Changed the requirement for building the Panama canal from the TNT invention to the "Drilling and Blasting" tech to avoid the invention's conditions delaying the construction of the canal. Closes #109 * National focus map mode fix by @Libeccio-DD - #112
@arkhometha I've had some good results before when it comes to massive refactorings of this kind. So if you do ever come up with a new scale, you can ping me and I'll see what I can do. |
To improve the visualization of life rating on the province's screen, the scale of the gfx was reduced by half, with 50 being the maximum. (Using the same trick, it is also possible to show a scale of 0-10 life rating, which would be better in my opinion, but it is necessary to test effects on migration and pop grow.)
A vanilla visual glitch in the needs meter was also fixed. The
progress.fxfunction cuts a line of pixels after processing the sprite, perhaps due to rounding error. Reduced and lightened beer foam, TGA transparency of the wine glass has been corrected.As it was before (1), what was changed (2), how it ended up (3).
