Condition adoption of writing system on modifier #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of the
establish_writing_system
decision (typo in the namefixed in this change) is to remove the crippling
lacks_writing_system
modifier when applicable. However the decision is only conditioned on
the related
lacking_writing_system
flag and not the modifier itself.Should a country lose the flag in some fashion, it would be stuck with
the debilitating modifier for the rest of the game. I don't believe that
this status can realistically be achieved in most games, though it is
not entirely outside the realm of possibility either. For instance an
organised
ARO
(aka Biafra) that managed impossibly high literacythrough colonial shenanigans might become eligible for
colonial_legacy
after release.
With this change the condition for the
establish_writing_system
decision correctly reflects its effect, namely by targeting the
lacks_writing_system
modifier. On top of that the modifier is alsoconsistently removed whenever the flag is.
This PR has been tested in artificial conditions, in countries with and without a writing system. (Events and Westernisation through RP points via console.)