Fix(eos_validate_state): Fix the DHCP not recognized error for STUN and Connectivity tests

[MaheshGSLAB]

Change Summary

Fix the DHCP not recognized error for STUN and Connectivity tests. If the interface is dhcp then AvdTestStun and AvdTestP2PIPReachability tests try to collect the ip address from interface cause below error.

TASK [arista.avd.eos_validate_state : Run eos_validate_state_runner] *********************************************************************************************************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ValueError: 'dhcp' does not appear to be an IPv4 or IPv6 interface
fatal: [Edge20]: FAILED! => {"changed": false, "msg": "Error during plugin execution: 'dhcp' does not appear to be an IPv4 or IPv6 interface"}

Related Issue(s)

Fixes #4725

Component(s) name

arista.avd.eos_validate_state

Proposed changes

Fix the DHCP not recognized error for STUN and Connectivity tests. If the interface is dhcp then AvdTestStun and AvdTestP2PIPReachability tests try to collect the ip address from interface cause below error.

Added the logic to check if interface is dhcp interface or not to avoid error.

How to test

Make the interface as DHCP and run the molecule. It should skip the test with below warning:

Host 'host1' interface 'Ethernet2' IP address is unavailable. AvdTestP2PIPReachability is skipped.
Host 'host1' interface 'Ethernet4' IP address is unavailable. AvdTestStun is skipped.

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4764
# Activate the virtual environment
source test-avd-pr-4764/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4725#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4725 --force
# Optional: Install AVD examples
cd test-avd-pr-4764
ansible-playbook arista.avd.install_examples

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[gmuloc]

@tonybourkesdnpros if you have time to test the PR it could be great!

[carl-baillargeon]

LGTM