Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(eos_validate_state): DHCP not recognized for Pathfinder interfaces #4725

Closed
1 task done
tonybourkesdnpros opened this issue Nov 14, 2024 · 2 comments · Fixed by #4764
Closed
1 task done

Bug(eos_validate_state): DHCP not recognized for Pathfinder interfaces #4725

tonybourkesdnpros opened this issue Nov 14, 2024 · 2 comments · Fixed by #4764
Assignees
Labels
type: bug Something isn't working

Comments

@tonybourkesdnpros
Copy link

tonybourkesdnpros commented Nov 14, 2024

Issue Summary

In a Pathfinder configuration, if an Edge node has the interface set for DHCP, eos_validate_state gives an error for that node and cannot create any reports.

Which component(s) of AVD impacted

eos_validate_state

How do you run AVD ?

Ansible CLI (with virtual-env or native python)

Steps to reproduce

Create a Pathfinder network with an Edge device that has an interface set for DHCP:

    - name: Edge22
      id: 22
      cv_pathfinder_region: REGION2
      cv_pathfinder_site: SITE22
      l3_interfaces:
        - name: Ethernet2
          ip_address: 172.16.22.2/24
          wan_carrier: mpls_r2
          flow_tracking:
            enabled: true
        - name: Ethernet3
          ip_address: dhcp
          wan_carrier: internet
          dhcp_accept_default_route: true
          peer_ip: 22.22.22.1
          dhcp_ip: 22.22.22.10
          flow_tracking:
            enabled: true
          cv_pathfinder_internet_exit: 
            policies:
              - name: DEFAULT_INTERNET_EXIT

Then run a playbook to validate state. This is the playbook I used:

---
- name: Validate state for Pathfinder
  hosts: PF_NETWORK
  tasks:
    - name: Validate states on EOS devices
      ansible.builtin.import_role:
        name: arista.avd.eos_validate_state

You can find a full topology here: https://github.com/tonybourkesdnpros/V3_Repo_Pathfinder.git

In the Pathfinder_MR directory, you'll find four edges configured via DHCP in Region2.

It doesn't appear that validate_state recognizes DHCP as a valid option. DHCP will probably be fairly common in Pathfinder deployments.



### Relevant log output

```shell
TASK [arista.avd.eos_validate_state : Run eos_validate_state_runner] *********************************************************************************************************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ValueError: 'dhcp' does not appear to be an IPv4 or IPv6 interface
fatal: [Edge20]: FAILED! => {"changed": false, "msg": "Error during plugin execution: 'dhcp' does not appear to be an IPv4 or IPv6 interface"}
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ValueError: 'dhcp' does not appear to be an IPv4 or IPv6 interface
fatal: [Edge22]: FAILED! => {"changed": false, "msg": "Error during plugin execution: 'dhcp' does not appear to be an IPv4 or IPv6 interface"}
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ValueError: 'dhcp' does not appear to be an IPv4 or IPv6 interface
fatal: [Edge23]: FAILED! => {"changed": false, "msg": "Error during plugin execution: 'dhcp' does not appear to be an IPv4 or IPv6 interface"}
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ValueError: 'dhcp' does not appear to be an IPv4 or IPv6 interface
fatal: [Edge24]: FAILED! => {"changed": false, "msg": "Error during plugin execution: 'dhcp' does not appear to be an IPv4 or IPv6 interface"}

Contributing Guide

  • I agree to follow this project's Code of Conduct
@tonybourkesdnpros tonybourkesdnpros added the type: bug Something isn't working label Nov 14, 2024
@tonybourkesdnpros tonybourkesdnpros changed the title DHCP Not Recognized in DHCP Not Recognized in eos_validate_state for Pathfinder interfaces Nov 14, 2024
@tonybourkesdnpros
Copy link
Author

Note: There's a token in the repo, however it's not an active token anywhere.

@ClausHolbechArista
Copy link
Contributor

Thank you for reporting! @carl-baillargeon would you have time to take a look at this? I guess we should just ignore the IP associated tests when the interface IP is DHCP.
We do have fields for the peer_ip, so if useful we could still use that to ping the peer?

@gmuloc gmuloc changed the title DHCP Not Recognized in eos_validate_state for Pathfinder interfaces Bug(eos_validate_state): DHCP not recognized for Pathfinder interfaces Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
4 participants