Refactor(eos_designs)!: Change loopback0 description and terminology to router_id_loopback

[ClausHolbechArista]

Change Summary

Change loopback0 description and terminology to router_id_loopback

Related Issue(s)

Fixes #4410

Component(s) name

arista.avd.eos_designs

Proposed changes

• Change loopback0 default description to ROUTER_ID
• Add new router_id_loopback_description and deprecate overlay_loopback_description
• Add new node_type_keys[].interface_descriptions.router_id_loopback_interface and deprecate node_type_keys[].interface_descriptions.overlay_loopback_interface
• Add new default value router_id for overlay_rd_type.admin_subfield and overlay_rd_type.vrf_admin_subfield and deprecate overlay_loopback_ip
• Update docs for custom descriptions

How to test

• Updated molecule scenarios to use the new vars
• Added the old vars to deprecated vars scenario
• Rerun all scenarios

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4448
# Activate the virtual environment
source test-avd-pr-4448/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/overlay-loopback-to-router-id-loopback#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/overlay-loopback-to-router-id-loopback --force
# Optional: Install AVD examples
cd test-avd-pr-4448
ansible-playbook arista.avd.install_examples

[Shivani-gslab]

LGTM!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud