Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs)!: Change the default Loopback1 description #4451

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Sep 10, 2024

Change Summary

Change the default Loopback1 description

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Change the default Loopback1 description to "VXLAN_TUNNEL_SOURCE"
  • Provide setting vtep_loopback_description to override the description

How to test

  • Added molecule test for the new setting
  • Reran all scenarios

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4451
# Activate the virtual environment
source test-avd-pr-4451/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/vtep-loopback-description#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/vtep-loopback-description --force
# Optional: Install AVD examples
cd test-avd-pr-4451
ansible-playbook arista.avd.install_examples

@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/vtep-loopback-description branch from 8938acd to 0a75660 Compare September 11, 2024 11:10
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review September 11, 2024 11:18
@ClausHolbechArista ClausHolbechArista requested review from a team as code owners September 11, 2024 11:18
@ClausHolbechArista ClausHolbechArista added this to the v5.0.0 milestone Sep 11, 2024
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@ClausHolbechArista ClausHolbechArista merged commit fdb0b6e into aristanetworks:devel Sep 13, 2024
40 checks passed
@ClausHolbechArista ClausHolbechArista deleted the refactor/eos_designs/vtep-loopback-description branch September 27, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Refactor(eos_designs)! role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants