Refactor(eos_cli_config_gen): Remove error handling for missing name in hardware-counters

ansible_collections/arista/avd/molecule/eos_cli_config_gen_negative_unit_tests/inventory/hosts.yml

@@ -3,6 +3,5 @@ all:
   children:
     EOS_CLI_CONFIG_GEN_NEGATIVE_TESTS:
       hosts:
-        hardware-counters:
         router-bfd-dangerous-interval-false:
         router-bfd-dangerous-interval-not-set:

python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/hardware-counters.j2

@@ -18,7 +18,6 @@
 | Feature | Flow Direction | Address Type | Layer3 | VRF | Prefix | Units Packets |
 | ------- | -------------- | ------------ | ------ | --- | ------ | ------------- |
 {%         for feature in hardware_counters.features | arista.avd.natural_sort("name") %}
-{%             do feature.name is arista.avd.defined(fail_action="error", var_name="The data model 'hardware_counters' changed in AVD4.0.0. 'hardware_counters.features.name'") %}
 {%             set feature_direction = feature.direction | arista.avd.default("-") %}
 {%             set feature_address_type = feature.address_type | arista.avd.default("-") %}
 {%             set feature_vrf = feature.vrf | arista.avd.default("-") %}

python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/hardware-counters.j2

@@ -7,10 +7,7 @@
 {% if hardware_counters.features is arista.avd.defined %}
 !
 {%     for feature in hardware_counters.features | arista.avd.natural_sort("name") %}
-{%         set hardware_counters_cli = "" %}
-{%         if feature.name is arista.avd.defined(fail_action="error", var_name="The data model 'hardware_counters' changed in AVD4.0.0. 'hardware_counters.features.name'") %}
-{%             set hardware_counters_cli = "hardware counter feature " ~ feature.name %}
-{%         endif %}
+{%         set hardware_counters_cli = "hardware counter feature " ~ feature.name %}
 {%         if feature.direction is arista.avd.defined %}
 {%             set hardware_counters_cli = hardware_counters_cli ~ " " ~ feature.direction %}
 {%         endif %}

python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/hardware_counters.schema.yml

@@ -54,7 +54,6 @@ keys:
               hardware counter feature route ipv4 vrf test 192.168.0.0/24
               ```
 
-        # primary_key: name
         # no primary key to allow multiple times the same name
         items:
           type: dict
@@ -92,6 +91,7 @@ keys:
                 - vni encap
                 - vtep decap
                 - vtep encap
+              required: true
             direction:
               type: str
               valid_values: