-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen): Remove error handling for missing name in hardware-counters #4302
Merged
ClausHolbechArista
merged 5 commits into
aristanetworks:devel
from
gmuloc:remove-hardware-counter
Aug 2, 2024
Merged
Refactor(eos_cli_config_gen): Remove error handling for missing name in hardware-counters #4302
ClausHolbechArista
merged 5 commits into
aristanetworks:devel
from
gmuloc:remove-hardware-counter
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in hardware-counters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4302
# Activate the virtual environment
source test-avd-pr-4302/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@remove-hardware-counter#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,remove-hardware-counter --force
# Optional: Install AVD examples
cd test-avd-pr-4302
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
Jul 31, 2024
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
state: conflict
PR with conflict
labels
Jul 31, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Quality Gate passedIssues Measures |
ClausHolbechArista
approved these changes
Jul 31, 2024
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Jul 31, 2024
laxmikantchintakindi
approved these changes
Aug 1, 2024
jrecchia1029
pushed a commit
to jrecchia1029/ansible-avd
that referenced
this pull request
Aug 14, 2024
…in hardware-counters (aristanetworks#4302)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Refactor(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
there was a model change that required some help when
name
was missing for hardware counter in 5.0. This PR addresses thisComponent(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Remove all the error handling about missing name
How to test
nothing to test
Checklist
Repository Checklist