Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_designs): Sanitize interface name in STUN profile name #3949

Merged
merged 1 commit into from
May 7, 2024
Merged

Fix(eos_designs): Sanitize interface name in STUN profile name #3949

merged 1 commit into from
May 7, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented May 6, 2024

Change Summary

Sanitize the STUN profile name generated by AVD by replacing / by _ when using interface name.
Checked that . is accepted.

Related Issue(s)

Fixes #3940

Component(s) name

arista.avd.eos_designs

Proposed changes

change the funciton generating the name1

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners May 6, 2024 11:14
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR role: eos_designs issue related to eos_designs role labels May 6, 2024
MaheshGSLAB
MaheshGSLAB approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on lab

@MaheshGSLAB MaheshGSLAB requested a review from a team May 7, 2024 08:36
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_designs): Sanitize intefrace name in STUN profile name Fix(eos_designs): Sanitize interface name in STUN profile name May 7, 2024
@ClausHolbechArista ClausHolbechArista merged commit 24595e4 into aristanetworks:devel May 7, 2024
40 checks passed
@gmuloc gmuloc mentioned this pull request May 13, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid Stun profile name generated
3 participants
@gmuloc @ClausHolbechArista @MaheshGSLAB