Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Stun profile name generated #3940

Closed
dgonzalez85 opened this issue May 3, 2024 · 1 comment · Fixed by #3949
Closed

Invalid Stun profile name generated #3940

dgonzalez85 opened this issue May 3, 2024 · 1 comment · Fixed by #3949
Assignees
Labels

Comments

@dgonzalez85
Copy link

Issue Summary

When using AWE5510/5310 devices, the physical interfaces are named et1/1, et2/1, etc.

When using one of those as path finder device, we automatically generate the stun client configuration in the Edge routers as follows, which includes the interface name:

router path-selection
   tcp mss ceiling ipv4 ingress
   !
   path-group internet id 101
      ipsec profile CP-PROFILE
      !
      local interface Ethernet1/9
         stun server-profile internet-PS-SITE-2-5310-Ethernet1/1 <--
      !
      local interface Ethernet1/10
         stun server-profile internet-PS-SITE-2-5310-Ethernet1/1 <--

stun
   client
      server-profile internet-PS-SITE-2-5310-Ethernet1/1 <--
         ip address 192.19.140.248
         ssl profile STUN-DTLS

However this stun profile is invalid since it contains a "/" character. EOS will not accept it, so we should use a hyphen or underscore.

Which component(s) of AVD impacted

eos_designs

How do you run AVD ?

Ansible CLI (with virtual-env or native python)

Steps to reproduce

The following RR node definition with "Ethernet1/1" will generate an invalid stun profile name:

wan_rr:
  defaults:
    loopback_ipv4_pool: 192.168.95.0/24
    vtep_loopback_ipv4_pool: 192.168.96.0/24
    # uplink_ipv4_pool: 172.21.176.0/24
    bgp_as: "19637"
    cv_pathfinder_region: EMEA
    cv_pathfinder_site: Amsterdam
    cv_pathfinder_transit_mode: "region"
    data_plane_cpu_allocation_max: 2
    platform: "AWE"
  nodes:
    - name: PS-SITE-2-5310
      id: 1
      mgmt_ip: 10.88.160.198/24
      # uplink_switch_interfaces: [Ethernet1]
      l3_interfaces:
        # This is a WAN interface because `wan_carrier` is defined
        - name: Ethernet1/1


### Relevant log output

_No response_

### Contributing Guide

- [X] I agree to follow this project's Code of Conduct
@dgonzalez85 dgonzalez85 added the type: bug Something isn't working label May 3, 2024
@gmuloc gmuloc self-assigned this May 6, 2024
@ClausHolbechArista
Copy link
Contributor

We will fix it by replacing / with _

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants