Feat(eos_designs): Custom platform_settings and node_type_keys #3300
Conversation
github-actions
bot
added
state: CI Updated
...ections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type_keys.schema.yml
Outdated
Show resolved
Hide resolved
|
Leaving as draft until #3078 is merged (first-class sflow support) as this PR is causing pyavd tests to fail currently. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
jonxstill
force-pushed
the
custom_settings
branch
from
1146bc5 to
5283407
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
jonxstill
force-pushed
the
custom_settings
branch
from
5283407 to
a97dbaa
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This PR is stale because it has been open 30 days with no activity. The PR will be reviewed by a maintainer and may be closed |
ClausHolbechArista
force-pushed
the
custom_settings
branch
from
a97dbaa to
717ea62
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
for more information, see https://pre-commit.ci
ClausHolbechArista
added
the
one approval
ansible_collections/arista/avd/roles/eos_designs/docs/input-variables.md
Outdated
Show resolved
Hide resolved
|
…anetworks#3300) Co-authored-by: Claus Holbech <[email protected]>
Change Summary
Allow use of
custom_platform_settingsandcustom_node_type_keysto allow replacement of already-defined keys/platforms, or addition of new keys/platforms while retaining the default settings.Related Issue(s)
Fixes #3152
Component(s) name
arista.avd.eos_designsProposed changes
Allows you to:
No changes to the data model - just use:
custom_platform_settingsinstead ofplatform_settings.custom_node_type_keysinstead ofnode_type_keys.How to test
Molecule tests updated to cover these new options. Problems encountered included AVD complaining about duplicate
node_type_keys- this was fixed through use ofreplace_or_append_item().This can be tested in your own repo by defining a
custom_platform_settingsand/orcustom_node_type_keysat a high level in your repo's hierarchy. Defaults can be copied from the AVD docs and amended as required.Checklist
Repository Checklist