Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Add sflow_settings #3078

Merged
merged 23 commits into from
Mar 25, 2024
Merged

Feat(eos_designs): Add sflow_settings #3078

merged 23 commits into from
Mar 25, 2024

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Aug 8, 2023 •
edited
Loading

Change Summary

Add sflow_settings

Component(s) name

arista.avd.eos_designs

Proposed changes

sflow_settings:
  destinations:
    - destination: <str>
      port: <int>
      vrf: <str>
  vrfs:
    - name: <str>
      source_inteface: <str>

How to test

Added to existing sFlow molecule tests.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Aug 8, 2023
@ClausHolbechArista ClausHolbechArista mentioned this pull request Aug 8, 2023
Merged
14 tasks
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos designs): Enhance sflow support Feat(eos_designs): Enhance sflow support Aug 10, 2023
@ClausHolbechArista ClausHolbechArista force-pushed the feat/eos_designs/enhance-sflow branch from 08e0d21 to 0bab3df Compare August 10, 2023 11:32
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs): Enhance sflow support Feat(eos_designs): Enhance sFlow support Aug 14, 2023
@github-actions github-actions bot added the state: conflict PR with conflict label Aug 24, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClausHolbechArista ClausHolbechArista force-pushed the feat/eos_designs/enhance-sflow branch from 7018005 to 63e1244 Compare September 22, 2023 08:56
@github-actions github-actions bot removed the state: conflict PR with conflict label Sep 22, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista force-pushed the feat/eos_designs/enhance-sflow branch from 63e1244 to cb5678d Compare October 26, 2023 06:15
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs): Enhance sFlow support Feat(eos_designs): Add sflow_settings Oct 27, 2023
jonxstill
jonxstill requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@jonxstill jonxstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor docs/schema changes. Tested this against a few different scenarios - works well IMO.

..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/sflow_settings.schema.yml Outdated Show resolved Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/sflow_settings.schema.yml Outdated Show resolved Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/sflow_settings.schema.yml Outdated Show resolved Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/sflow_settings.schema.yml Outdated Show resolved Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/sflow_settings.schema.yml Outdated Show resolved Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/sflow_settings.schema.yml Outdated Show resolved Hide resolved
...le_collections/arista/avd/roles/eos_designs/schemas/schema_fragments/fabric_sflow.schema.yml Outdated Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review October 31, 2023 10:56
@ClausHolbechArista ClausHolbechArista requested review from a team as code owners October 31, 2023 10:56
jonxstill
jonxstill previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@jonxstill jonxstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonxstill jonxstill mentioned this pull request Nov 1, 2023
Merged
4 tasks
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Nov 2, 2023
@ClausHolbechArista ClausHolbechArista marked this pull request as draft November 8, 2023 11:01
pmerlo2022
pmerlo2022 reviewed Nov 10, 2023
View reviewed changes
Copy link

@pmerlo2022 pmerlo2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time reviewing an AVD PR ... tested the changes and they work as advertised. Just a couple of comments on the docs and schema.

ansible_collections/arista/avd/roles/eos_designs/schemas/eos_designs.schema.yml Outdated Show resolved Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/sflow_settings.schema.yml Show resolved Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/sflow_settings.schema.yml Outdated Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review November 10, 2023 09:45
@ClausHolbechArista
Copy link
Contributor Author

@jonxstill @pmerlo2022 thank you for your reviews. I have updated the data model a bit since Jon reviewed, to be simpler for VRF. And for both of you I just added support for the new default_mgmt_method so it respects that if you don't set the VRF.

@ClausHolbechArista ClausHolbechArista removed the one approval This PR has one approval and is only missing one more. label Nov 10, 2023
ClausHolbechArista and others added 16 commits March 14, 2024 11:54
@ClausHolbechArista
Refactor to detect sflow enabled interfaces
4cbe81d
@ClausHolbechArista
Rearrange schemas and improve descriptions
5c7b76c
@ClausHolbechArista
remove comments
8188b10
@ClausHolbechArista
various updates after rename
c927642
@ClausHolbechArista @jonxstill
Apply suggestions from code review
d27a8c4 
Co-authored-by: Jon Still <[email protected]>
@ClausHolbechArista
Update schemas after review suggestions
c378cf5
@ClausHolbechArista
Fix
a0e40db
@ClausHolbechArista
Simplify data model
6c6e08e
@ClausHolbechArista
Update schema based on review comments.
9e62ddc
@ClausHolbechArista
Add support for default_mgmt_method
cb171e7
@ClausHolbechArista
Add support for default_mgmt_method
8c181d0
@ClausHolbechArista
too much copy-paste
5722980
@ClausHolbechArista @gmuloc
Update ansible_collections/arista/avd/roles/eos_designs/schemas/schem…
af221ea 
…a_fragments/sflow_settings.schema.yml

Co-authored-by: Guillaume Mulocher <[email protected]>
@ClausHolbechArista
Update ansible_collections/arista/avd/roles/eos_designs/docs/input-va…
283eecf 
…riables.md
@carlbuchmann @ClausHolbechArista
re-run pre-commit
d8c7912
@ClausHolbechArista
Add vrfs model instead of structured config
c869503
@ClausHolbechArista ClausHolbechArista force-pushed the feat/eos_designs/enhance-sflow branch from a5e4dd8 to c869503 Compare March 14, 2024 10:59
@github-actions github-actions bot removed the state: conflict PR with conflict label Mar 14, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@carlbuchmann carlbuchmann dismissed jonxstill’s stale review March 18, 2024 15:04

PR has new changes

@carlbuchmann carlbuchmann requested a review from pmerlo2022 March 18, 2024 15:12
@ClausHolbechArista ClausHolbechArista merged commit b0ec802 into aristanetworks:devel Mar 25, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonxstill jonxstill jonxstill left review comments

@gmuloc gmuloc gmuloc approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

@alexeygorbunov alexeygorbunov Awaiting requested review from alexeygorbunov

@pmerlo2022 pmerlo2022 Awaiting requested review from pmerlo2022

Assignees

@carlbuchmann carlbuchmann

@ClausHolbechArista ClausHolbechArista

Labels
EPIC - Improve Campus Support rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ClausHolbechArista @gmuloc @jonxstill @pmerlo2022 @carlbuchmann