-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(anta.cli)!: Avoid requiring username, password, inventory for the get commands #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmuloc
changed the title
Fix(anta.cli): Avoid requiring username, password, inventory for the get commands
fix(anta.cli): Avoid requiring username, password, inventory for the get commands
Nov 9, 2023
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
6 tasks
gmuloc
commented
Nov 21, 2023
gmuloc
force-pushed
the
issue/355
branch
2 times, most recently
from
November 24, 2023 14:50
8caa26e
to
be526d7
Compare
Co-authored-by: Guillaume Mulocher <[email protected]>
Co-authored-by: Guillaume Mulocher <[email protected]>
Co-authored-by: Guillaume Mulocher <[email protected]>
Co-authored-by: Guillaume Mulocher <[email protected]>
Co-authored-by: Guillaume Mulocher <[email protected]>
titom73
reviewed
Dec 4, 2023
gmuloc
commented
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mtache
approved these changes
Dec 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we have 2 ways of solving the problem:
required
with some custom Group / callbacks to relax the requirement depending on the command being called. It turns out to be more cumbersome as we need to inject the CLI arguments in the context to pass to the callback. An alternative is to write all the logic in the custom Group class which may allow us to keep therequired=True
on username and inventory (and so, see it in the help, though in the help well having required on some options that is ONLY SOMETIMES required option is meeeeh)Fixes #355, #479 (duplicate)
Decision taken is to move the CLI option NOW before we release v1.0.0 to not live with our previous decisions.
This turned this PR in some heavy but very welcomed refactoring from @mtache
Checklist:
pre-commit run
)tox -e testenv
)